Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add overrideable _versionHash to ERC20 #1094

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

Vectorized
Copy link
Owner

Description

In case for some reason, a version other than "1" is needed.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

Copy link

Gas Snapshot Comparison Report

Generated at commit : 8f92b50, Compared to commit : 5b49c64

Contract Name Test Name Main Gas PR Gas Diff
CREATE3Test testDeployERC20() 780674 781227 553
testDoubleDeployDifferentBytecodeReverts() 96898724 96898738 14
test__codesize() 13856 13860 4
ERC20ForPermit2Test test__codesize() 8965 8967 2
ERC20Invariants test__codesize() 7276 7278 2
ERC20Test testPermit() 89369 89379 10
test__codesize() 22606 22608 2
ERC4626Test testTryGetAssetDecimals() 30674026 30687274 13248
testUseVirtualShares() 2426848 2427648 800
testVirtualSharesMultipleMintDepositRedeemWithdraw() 1614279 1614679 400
test__codesize() 36899 36903 4
LifebuoyTest test__codesize() 45951 45953 2
SafeTransferLibTest testApproveWithRetry() 789340 789740 400
testPermit2() 90097 90112 15
testTransferFromWithMissingReturn() 542513 542551 38
testTransferFromWithReturnsFalseReverts() 508851 508931 80
testTransferFromWithReturnsTooLittleReverts() 508583 508642 59
testTransferFromWithReturnsTooMuch() 543405 543464 59
testTransferFromWithRevertingReverts() 501317 501397 80
testTransferWithMissingReturn() 529120 529179 59
testTransferWithReturnsTooLittleReverts() 505564 505585 21
testTransferWithRevertingReverts() 776726 776822 96
testTransferWithStandardERC20() 530015 530079 64
test__codesize() 65977 65981 4
WETHInvariants test__codesize() 5176 5178 2
WETHTest test__codesize() 9408 9410 2

@Vectorized Vectorized merged commit 1e443c2 into main Sep 25, 2024
14 checks passed
@Vectorized Vectorized deleted the erc20-custom-version branch September 25, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant