✨ ERC20Votes #1127
Merged
✨ ERC20Votes #1127
+1,097
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atarpara Help me review. I'm only 90% confident. |
atarpara
approved these changes
Oct 16, 2024
| sstore(checkpointSlot, or(or(key, shl(48, n)), shl(96, newValue))) | ||
| break | ||
| } | ||
| sstore(checkpointSlot, or(or(key, shl(48, n)), shl(96, address()))) |
There was a problem hiding this comment.
Awesome. It's very interesting see how did you manage 2**256-1 range.
| } | ||
| newValue := add(oldValue, amount) | ||
| if iszero(lt(newValue, oldValue)) { break } | ||
| mstore(0x00, 0x9dbbeb75) // `ERC5805CheckpointValueOverflow()`. |
There was a problem hiding this comment.
It's unreachable condition or path bcz totalSupply() never exceeds type(uint256).max value
There was a problem hiding this comment.
This is incase someone overrides the voting units function to return a multiple of balance
| if iszero(isAdd) { | ||
| newValue := sub(oldValue, amount) | ||
| if iszero(gt(newValue, oldValue)) { break } | ||
| mstore(0x00, 0x5915f686) // `ERC5805CheckpointValueUnderflow()`. |
There was a problem hiding this comment.
It's unreachable condition or path bcz totalSupply() never exceeds type(uint256).max value
src/tokens/ERC20Votes.sol
Outdated
| } | ||
| h := m | ||
| } | ||
| if h { |
There was a problem hiding this comment.
It should be converted into branch less to save gas and codesize
let checkpointSlot := add(sub(h, 1), lengthSlot)
result := mul(iszero(iszero(h)), shr(96, sload(checkpointSlot))
if eq(result, address()) { result := sload(not(checkpointSlot)) }`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ready for review
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge fmt?forge test?Pull requests with an incomplete checklist will be thrown out.