fix: replaces aa and Aa with ah and Ah to avoid oddvoice weirdness

VehpuS · Apr 26, 2024 · f941e3e · f941e3e
1 parent eeb6045
commit f941e3e
Show file tree

Hide file tree

Showing 4 changed files with 993 additions and 0 deletions.
diff --git a/musicxml-singer-with-oddvoices/src/oddVoiceJSON/lyricsHelpers.ts b/musicxml-singer-with-oddvoices/src/oddVoiceJSON/lyricsHelpers.ts
@@ -19,6 +19,11 @@ export const modifyLyricsForOddvoices = (lyrics: string): string => {
     modifiedLyrics = modifiedLyrics.replace(/Ooo+/g, "Oo");
     modifiedLyrics = modifiedLyrics.replace(/ooo+/g, "oo");
 
+    // Replace all repeated aas (more than 2) with ah. For example, "Aaaa" -> "Ah"
+    // For some reason, oddvoices will read "aa" as "ay ay" instead of "ah", and splitting them into separate notes
+    modifiedLyrics = modifiedLyrics.replace(/Aa+/g, "Ah");
+    modifiedLyrics = modifiedLyrics.replace(/aa+/g, "ah");
+
     modifiedLyrics = modifiedLyrics.trim();
     return modifiedLyrics;
 };
diff --git a/musicxml-singer-with-oddvoices/src/oddVoiceJSON/tests/aaToAhTest.mscz b/musicxml-singer-with-oddvoices/src/oddVoiceJSON/tests/aaToAhTest.mscz