Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSX leading space in translations #3195

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

0xThiebaut
Copy link
Contributor

Fix JSX leading space for tags in translations. As an example, malmoeb's post displays the following capture where the link is not spaced from the text (fromhttps://).

cdbf6801ad02d31e

This commit ensures any tags within the JSX translations are prefixed with text to avoid accidental white space trimming.

image

@scudette scudette merged commit 7d7c6f8 into Velocidex:master Jan 17, 2024
3 checks passed
@0xThiebaut 0xThiebaut deleted the spaces branch January 17, 2024 08:07
scudette pushed a commit that referenced this pull request Feb 15, 2024
Fix JSX leading space for tags in translations. As an example,
[malmoeb's post](https://infosec.exchange/@malmoeb/111675841615532732)
displays the following capture where the link is not spaced from the
text (`fromhttps://`).

<img width="475" alt="cdbf6801ad02d31e"
src="https://github.com/Velocidex/velociraptor/assets/46688461/cf8c387c-69d7-4c46-ab76-6534d8599cd2">

This commit ensures any tags within the JSX translations are prefixed
with text to avoid accidental white space trimming.


![image](https://github.com/Velocidex/velociraptor/assets/46688461/6ba458aa-ef2a-4825-bb07-610b6766e55a)
scudette pushed a commit that referenced this pull request Feb 15, 2024
Fix JSX leading space for tags in translations. As an example,
[malmoeb's post](https://infosec.exchange/@malmoeb/111675841615532732)
displays the following capture where the link is not spaced from the
text (`fromhttps://`).

<img width="475" alt="cdbf6801ad02d31e"
src="https://github.com/Velocidex/velociraptor/assets/46688461/cf8c387c-69d7-4c46-ab76-6534d8599cd2">

This commit ensures any tags within the JSX translations are prefixed
with text to avoid accidental white space trimming.


![image](https://github.com/Velocidex/velociraptor/assets/46688461/6ba458aa-ef2a-4825-bb07-610b6766e55a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants