Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: species dropdown connected to backend #100

Merged
merged 13 commits into from
Dec 3, 2023
Merged

feat: species dropdown connected to backend #100

merged 13 commits into from
Dec 3, 2023

Conversation

xnought
Copy link
Member

@xnought xnought commented Dec 2, 2023

#99

Screen.Recording.2023-12-02.at.3.22.14.PM.mov

Notes

  • when you run this, make sure to do ./run.sh reload_init_sql since there are changes there
  • to simplify I changed the species table to only contain name instead of genus and species. This is just for now, it was easier.
  • Also added autoincrement ids to the proteins and species as their primary keys

Copy link
Collaborator

@CoraBailey CoraBailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, let's merge it.

@ansengarvin
Copy link
Collaborator

I think it's ready for merge, but some things we should consider for down the line:

  1. In bionomial nomenclature, Genus is capitalized, e.g. "Genus species" instead of "genus species". The primary key should probably stay all-lowercase for simplicity, but we should capitalize the genus prior to displaying to the user.
  2. I originally separated tax_genus from tax_species to make it easier to use in cojunction with the NCBI Taxonomy Browser. If we choose to use the taxonomy browser, we will have to use some other tool like Regex to separate genus from species.

@xnought xnought merged commit 4935364 into main Dec 3, 2023
3 checks passed
@xnought xnought deleted the hookup-dropdown branch December 3, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants