Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Laravel 10 support #419

Closed
wants to merge 3 commits into from
Closed

add Laravel 10 support #419

wants to merge 3 commits into from

Conversation

pxpm
Copy link

@pxpm pxpm commented Jan 31, 2023

No description provided.

@tabacitu
Copy link
Contributor

tabacitu commented Feb 1, 2023

Thanks Pedro! It was that easy, huh?

@pxpm
Copy link
Author

pxpm commented Feb 9, 2023

Hey guys, i've also updated dev dependencies.

There were some issues with tests, I fixed two of them.
The return type of the setUp method and the database name.
The change on return type may be a breaking change, so it's probably better to tag a new version with only l10+ support with PHPUnit 9.5+ ?

Tests are now running and green, but we still have some issues with PHPUnit xml file.
I think the invalid attributes are just disregarded so the tests run fine:

Using PHPUnit 10.x

image

Using PHPUnit 9.6x

image

I also tested revisionable on our use case, it seems to be working fine:
image

Cheers

@duellsy
Copy link
Member

duellsy commented Feb 18, 2023

Laravel 10 support merged in with #420

@duellsy duellsy closed this Feb 18, 2023
@niladam
Copy link

niladam commented Feb 18, 2023

@duellsy thank you! @pxpm thank you too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants