move appender ignore to serialization stage (#1337)

VerifyTests · Nov 1, 2024 · 664a79a · 664a79a
1 parent e1e1910
commit 664a79a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 18 deletions.
diff --git a/src/Verify/Serialization/InfoBuilder.cs b/src/Verify/Serialization/InfoBuilder.cs
@@ -70,6 +70,11 @@ public override void Write(VerifyJsonWriter writer, InfoBuilder value)
 
             foreach (var item in value.inner)
             {
+                if (writer.serialization.ShouldIgnoreByName(item.Key))
+                {
+                    continue;
+                }
+
                 writer.WritePropertyName(item.Key);
                 if (writer.serialization.ShouldScrubByName(item.Key))
                 {

diff --git a/src/Verify/Splitters/Settings_JsonAppender.cs b/src/Verify/Splitters/Settings_JsonAppender.cs
@@ -10,13 +10,7 @@ internal static List<ToAppend> GetJsonAppenders(VerifySettings settings)
 
         if (Recording.TryStop(out var recorded))
         {
-            foreach (var append in recorded)
-            {
-                if (!settings.serialization.ShouldIgnoreByName(append.Name))
-                {
-                    list.Add(append);
-                }
-            }
+            list.AddRange(recorded);
         }
 
         foreach (var appender in jsonAppenders)
@@ -25,21 +19,12 @@ internal static List<ToAppend> GetJsonAppenders(VerifySettings settings)
             if (data is not null)
             {
                 var append = data.Value;
-                if (!settings.serialization.ShouldIgnoreByName(append.Name))
-                {
-                    list.Add(append);
-                }
-            }
-        }
-
-        foreach (var append in settings.Appends)
-        {
-            if (!settings.serialization.ShouldIgnoreByName(append.Name))
-            {
                 list.Add(append);
             }
         }
 
+        list.AddRange(settings.Appends);
+
         return list;
     }