Merge branch 'main' of https://github.com/VerifyTests/Verify

VerifyTests · Jul 26, 2024 · ecf64d5 · ecf64d5
2 parents 0ddf9cb + 3f8adb0
commit ecf64d5
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/docs/mdsource/recording.source.md b/docs/mdsource/recording.source.md
@@ -51,6 +51,8 @@ To avoid grouping use [Stop](#stop).
 
 Recording can be grouped by an identifier.
 
+The identifier should be statically unique. For example a fully qualified test name or a GUID.
+
 snippet: RecordingIdentifier
 
 Results in:

diff --git a/docs/recording.md b/docs/recording.md
@@ -143,6 +143,8 @@ To avoid grouping use [Stop](#stop).
 
 Recording can be grouped by an identifier.
 
+The identifier should be statically unique. For example a fully qualified test name or a GUID.
+
 <!-- snippet: RecordingIdentifier -->
 <a id='snippet-RecordingIdentifier'></a>
 ```cs

diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -2,7 +2,7 @@
 <Project>
   <PropertyGroup>
     <NoWarn>CS1591;CS0649;xUnit1026;xUnit1013;CS1573;VerifyTestsProjectDir;VerifySetParameters;PolyFillTargetsForNuget</NoWarn>
-    <Version>26.1.1</Version>
+    <Version>26.1.2</Version>
     <ImplicitUsings>enable</ImplicitUsings>
     <LangVersion>preview</LangVersion>
     <AssemblyVersion>1.0.0</AssemblyVersion>

diff --git a/src/Verify/Recording/Recording_Named.cs b/src/Verify/Recording/Recording_Named.cs
@@ -2,6 +2,8 @@
 
 public static partial class Recording
 {
+    // The identifier should be statically unique. For example a fully qualified test name or a GUID.
+    // so it is ok for this to be shared state
     static ConcurrentDictionary<string, State> namedState = new(StringComparer.OrdinalIgnoreCase);
 
     public static void Add(string identifier, string name, object item) =>