Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move playwright-go from mxschmitt to playwright-community #982

Merged
merged 5 commits into from
Mar 13, 2023
Merged

Move playwright-go from mxschmitt to playwright-community #982

merged 5 commits into from
Mar 13, 2023

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Mar 11, 2023

#952

I didn't test browser path of resulting binary

@mapkon
Copy link
Member

mapkon commented Mar 12, 2023

#952

I didn't test browser path of resulting binary

Thanks @gliptak - how would we verify that?

@gliptak
Copy link
Contributor Author

gliptak commented Mar 12, 2023

while there might be coverage in tests, considering the large space of environments, maybe issue submitters could be requested to test PR builds?

#984
https://github.com/Versent/saml2aws/actions/runs/4398152074
https://github.com/Versent/saml2aws/suites/11507705184/artifacts/594845640

@mapkon
Copy link
Member

mapkon commented Mar 12, 2023

https://github.com/Versent/saml2aws/suites/11507705184/artifacts/594845640

That is a good point. Alternatively, the author can also list the environments where they need help testing. That way, we can rally efforts around verifying the change.

A case could be made that it might not be necessarily for a library change like this one, but without a test suite to exercise the execution paths, it is really guessing if everything is right!

@gliptak
Copy link
Contributor Author

gliptak commented Mar 13, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants