Use methods when there is state. Removed dead code. Default to not export. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojongerius
changed the title
…he package. Converted some functions to be methods.
* upstream/master: Adhere to Go standards. Short options where it makes sense.
ojongerius
changed the title
|
Some extra context/information: I've mainly opened this PR for discussion. Tests pass but I've not ran any integration tests. Have opened #17 for adding some. |
* Can be more compact when only checking for error * Update doco to reflect method / function renaming * Fmt * Refactor GetAllSecrets into a method
…in and into package.
|
Really need to break this into pieces, it is really hard for me to review in it's current state.
Again i would love it if you could break these up. |
|
Cool. this was me being stuck in an airplane and getting a little carried away. I'll break this up into a few PRs so it's a little more manageable. |
|
@ojongerius no problem at all, totally understand the feeling. I was tempted to cherry pick but would prefer you just undid the commits and broke it up into bite size chunks to preserve your contributions. Thanks again. |
This was referenced Mar 22, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a fair amount of getting both values and errors, followed by passing those values to another function.
While going through the code I stumbled on some dead code, which I removed. I also moved the zone helper function out of main (as you planned on doing), and renamed functions that were not used outside of the package to not be exported.