Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check status code first to help debug test failure #829

Merged
merged 1 commit into from
Jun 21, 2020
Merged

Check status code first to help debug test failure #829

merged 1 commit into from
Jun 21, 2020

Conversation

convoliution
Copy link
Contributor

@convoliution convoliution commented Jun 21, 2020 •
edited
Loading

These tests are failing because of an issue with httpbin.

If the status check happened first, it would've given a better indication as to what happened (a 404).

@convoliution convoliution self-assigned this Jun 21, 2020
@convoliution convoliution merged commit 6b5e12d into master Jun 21, 2020
@convoliution convoliution deleted the client/ml/test branch June 21, 2020 01:52
@convoliution
Copy link
Contributor Author

Oh boy now that issue on httpbin has a link to this PR. That's awkward.

@convoliution convoliution changed the title Check status code first to help debug Check status code first to help debug test failure Jun 21, 2020
@convoliution convoliution mentioned this pull request Jun 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradoverta conradoverta Awaiting requested review from conradoverta

Assignees

@convoliution convoliution

Labels
python-client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@convoliution