Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tighten template dependencies #137

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 2, 2024

Tighten dependencies for all direct hosted dependencies in templated pubspec.yaml files.

@github-actions github-actions bot requested a review from a team as a code owner July 2, 2024 12:57
@github-actions github-actions bot added the bot label Jul 2, 2024
@alestiago alestiago closed this Jul 2, 2024
@alestiago alestiago reopened this Jul 2, 2024
@alestiago alestiago added the p1 High-priority issues at the top of the work list label Jul 3, 2024
@alestiago alestiago self-assigned this Jul 3, 2024
@alestiago
Copy link
Contributor

alestiago commented Jul 3, 2024

I was able to reproduce the CI error locally:

  1. Generate the Very Good Flame Game template (from very_good_templates):
mason make very_good_flame_game -o output
  1. Get the project dependencies (from very_good_templates/output/my_game):
flutter pub get
  1. Run all the tests (from very_good_templates/output/my_game):
flutter test test/game/view/game_page_test.dart # Test fails
  1. Run only the tests in "test/game/view/game_page_test.dart " (from very_good_templates/output/my_game):
flutter test test/game/view/game_page_test.dart  # Test fails
  1. Run the failing test (from very_good_templates/output/my_game):
flutter test test/game/view/game_page_test.dart --name "is routable" # Test passes

@alestiago alestiago added this pull request to the merge queue Jul 3, 2024
Merged via the queue into main with commit 2b62436 Jul 3, 2024
27 checks passed
@alestiago alestiago deleted the vgvbot/dependency_tightener branch July 3, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot p1 High-priority issues at the top of the work list
Projects
Development

Successfully merging this pull request may close these issues.

2 participants