Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYB 018/upgrade to 1.15.7 #34

Merged
merged 13 commits into from
Nov 15, 2023
Merged

SYB 018/upgrade to 1.15.7 #34

merged 13 commits into from
Nov 15, 2023

Conversation

vereis
Copy link
Collaborator

@vereis vereis commented Oct 23, 2023

Preparation to upgrade Sibyl to support Elixir 1.15.7 and fixes a few various linting/runtime issues as a result.

  • Update shell.nix and .tool-versions
  • Fix bad dialyzer typespec
  • Fix deprecation warnings
  • Fix credo warnings about inspect/1 calls inside of string building
  • Fix credo warning about unsafe to_atom/1
  • Fix failing test due to changes in String.is_valid?/2
  • Fix bug where newer versions of Elixir would crash reflecting on the :shell_default module -- ignore all erlang modules
  • Update deps

Copy link

@rob-vetspire rob-vetspire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are these changes backwards compatible with previous Elixir versons?

@vereis vereis force-pushed the SYB-018/upgrade-to-1.15.7 branch 3 times, most recently from dce20c3 to 865b0cb Compare October 24, 2023 10:58
@vereis vereis marked this pull request as ready for review October 24, 2023 10:58
@vereis vereis force-pushed the SYB-018/upgrade-to-1.15.7 branch 4 times, most recently from d07e14f to 16aebe7 Compare October 24, 2023 11:00
@vereis vereis enabled auto-merge (rebase) November 15, 2023 12:16
auto-merge was automatically disabled November 15, 2023 12:21

Rebase failed

@vereis vereis enabled auto-merge (rebase) November 15, 2023 12:23
@vereis vereis merged commit ac8a841 into main Nov 15, 2023
2 checks passed
@vereis vereis deleted the SYB-018/upgrade-to-1.15.7 branch November 15, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants