-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SYB 018/upgrade to 1.15.7 #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob-vetspire
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Are these changes backwards compatible with previous Elixir versons?
vereis
force-pushed
the
SYB-018/upgrade-to-1.15.7
branch
3 times, most recently
from
October 24, 2023 10:58
dce20c3
to
865b0cb
Compare
vereis
force-pushed
the
SYB-018/upgrade-to-1.15.7
branch
4 times, most recently
from
October 24, 2023 11:00
d07e14f
to
16aebe7
Compare
auto-merge was automatically disabled
November 15, 2023 12:21
Rebase failed
…`:shell_default` module -- ignore all erlang modules
vereis
force-pushed
the
SYB-018/upgrade-to-1.15.7
branch
from
November 15, 2023 12:23
d8efc35
to
b19d289
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation to upgrade Sibyl to support Elixir 1.15.7 and fixes a few various linting/runtime issues as a result.
shell.nix
and.tool-versions
inspect/1
calls inside of string buildingto_atom/1
String.is_valid?/2
:shell_default
module -- ignore all erlang modules