Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type piracy with OffsetArrays #3

Open
Vexatos opened this issue Feb 3, 2020 · 1 comment
Open

Type piracy with OffsetArrays #3

Vexatos opened this issue Feb 3, 2020 · 1 comment

Comments

@Vexatos
Copy link
Owner

Vexatos commented Feb 3, 2020 •
edited
Loading

See #2 (comment) by @yha and JuliaArrays/OffsetArrays.jl#87. This needs to be solved, but there currently isn't any good way to do that. Would probably have to create a hard dependency on OffsetArrays until this is fixed in Base, which is really ugly and I'd rather not do it.
@Vexatos
Copy link
Owner Author

Vexatos commented Feb 3, 2020 •
edited
Loading

Another option might be to use Requires.jl at least until JuliaLang/Pkg.jl#1285 is resolved. That's also very ugly and the glue code won't precompile, but it is probably better than a hard dependency, although it'd just be a hard dependency on Requires instead...

Vexatos added a commit that referenced this issue Feb 3, 2020
@Vexatos
Added OffsetArrays as hard dependency.
df3c8bf 
This will fix it for now, but I hope this can be resolved properly at a
later date, possibly when conditional depdenencies are added to Pkg.jl

See #3.
@Vexatos Vexatos mentioned this issue Nov 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Vexatos