Sema: fix comptime only types being allowed on extern functions

Closes ziglang#13022
Vexu · Oct 5, 2022 · badbf04 · badbf04
1 parent ba4aa12
commit badbf04
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/Sema.zig b/src/Sema.zig
@@ -7970,7 +7970,7 @@ fn funcCommon(
                 i,
                 &is_generic,
                 cc_workaround,
-                has_body,
+                has_body or is_extern,
             ) catch |err| switch (err) {
                 error.NeededSourceLocation => {
                     const decl = sema.mod.declPtr(block.src_decl);
@@ -7982,7 +7982,7 @@ fn funcCommon(
                         i,
                         &is_generic,
                         cc_workaround,
-                        has_body,
+                        has_body or is_extern,
                     );
                     return error.AnalysisFail;
                 },

diff --git a/test/cases/compile_errors/comptime_only_params_not_allowed_on_extern_fns.zig b/test/cases/compile_errors/comptime_only_params_not_allowed_on_extern_fns.zig
@@ -0,0 +1,12 @@
+pub extern fn signal(handler: fn (c_int, c_int) callconv(.C) void) void;
+fn interruptFn(_: c_int, _: c_int) callconv(.C) void {}
+
+pub export fn entry() void {
+    _ = signal(interruptFn);
+}
+
+// error
+// backend=stage2
+// target=native
+//
+// :1:22: error: parameter of type 'fn(c_int, c_int) callconv(.C) void' must be declared comptime