feat(httperror): Set up a default func for ignoreable error

Signed-off-by: Vincent Boutour <bob@vibioh.fr>
ViBiOh · Aug 26, 2024 · 18bce45 · 18bce45
1 parent 8b02d9d
commit 18bce45
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 5 deletions.
diff --git a/pkg/cache/list.go b/pkg/cache/list.go
@@ -2,11 +2,11 @@ package cache
 
 import (
 	"context"
-	"errors"
 	"fmt"
 	"log/slog"
 
 	"github.com/ViBiOh/httputils/v4/pkg/concurrent"
+	"github.com/ViBiOh/httputils/v4/pkg/httperror"
 	"github.com/ViBiOh/httputils/v4/pkg/telemetry"
 	"go.opentelemetry.io/otel/trace"
 )
@@ -168,7 +168,7 @@ func (c *Cache[K, V]) redisValues(ctx context.Context, ids []K) ([]string, []str
 	values, err := c.read.LoadMany(loadCtx, keys...)
 	if err != nil {
 		level := slog.LevelError
-		if errors.Is(err, context.Canceled) {
+		if httperror.CanBeIgnored(err) {
 			level = slog.LevelWarn
 		}
 

diff --git a/pkg/httperror/error.go b/pkg/httperror/error.go
@@ -5,6 +5,7 @@ import (
 	"errors"
 	"log/slog"
 	"net/http"
+	"syscall"
 
 	"github.com/ViBiOh/httputils/v4/pkg/model"
 )
@@ -13,6 +14,14 @@ const (
 	internalError = "Oops! Something went wrong. Server's logs contain more details."
 )
 
+func CanBeIgnored(err error) bool {
+	if err == nil {
+		return true
+	}
+
+	return errors.Is(err, syscall.EPIPE) || errors.Is(err, syscall.ECONNRESET) || errors.Is(err, context.Canceled)
+}
+
 func httpError(ctx context.Context, w http.ResponseWriter, status int, payload string, err error) {
 	w.Header().Add("Cache-Control", "no-cache")
 	http.Error(w, payload, status)

diff --git a/pkg/pprof/pprof.go b/pkg/pprof/pprof.go
@@ -3,7 +3,6 @@ package pprof
 import (
 	"bytes"
 	"context"
-	"errors"
 	"flag"
 	"fmt"
 	"log/slog"
@@ -14,6 +13,7 @@ import (
 	"time"
 
 	"github.com/ViBiOh/flags"
+	"github.com/ViBiOh/httputils/v4/pkg/httperror"
 	"github.com/ViBiOh/httputils/v4/pkg/recoverer"
 	"github.com/ViBiOh/httputils/v4/pkg/request"
 )
@@ -92,7 +92,7 @@ func (s *Service) push(ctx context.Context) {
 		case <-ctx.Done():
 			return
 		case <-ticker.C:
-			if err := s.send(ctx); err != nil && !errors.Is(err, context.Canceled) {
+			if err := s.send(ctx); !httperror.CanBeIgnored(err) {
 				slog.LogAttrs(ctx, slog.LevelError, "pprof export", slog.Any("error", err))
 			}
 		}

diff --git a/pkg/redis/redis.go b/pkg/redis/redis.go
@@ -10,6 +10,7 @@ import (
 	"time"
 
 	"github.com/ViBiOh/flags"
+	"github.com/ViBiOh/httputils/v4/pkg/httperror"
 	"github.com/ViBiOh/httputils/v4/pkg/model"
 	"github.com/ViBiOh/httputils/v4/pkg/recoverer"
 	"github.com/redis/go-redis/extra/redisotel/v9"
@@ -115,7 +116,7 @@ func (s *Service) Load(ctx context.Context, key string) ([]byte, error) {
 		return content, nil
 	}
 
-	if err != redis.Nil && !errors.Is(err, context.Canceled) {
+	if err != redis.Nil && !httperror.CanBeIgnored(err) {
 		return nil, fmt.Errorf("exec get: %w", err)
 	}