Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix map color rewriting not working for 1.17 -> 1.16.4 #956

Merged
merged 2 commits into from
Feb 2, 2025
Merged

Fix map color rewriting not working for 1.17 -> 1.16.4 #956

merged 2 commits into from
Feb 2, 2025

Conversation

booky10
Copy link
Contributor

@booky10 booky10 commented Feb 2, 2025

Map color rewriting was only working when the map data packet would have decorations

booky10 and others added 2 commits February 2, 2025 17:32
FlorianMichael
FlorianMichael approved these changes Feb 2, 2025
View reviewed changes
Copy link
Member

@FlorianMichael FlorianMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Pushed a slight cleanup to avoid the icons boolean and instead have a rewrite function, which is the common pattern in other rewriters (e.g EntityRewriter) as well.

@FlorianMichael FlorianMichael merged commit c6b287b into ViaVersion:master Feb 2, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianMichael FlorianMichael FlorianMichael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@booky10 @FlorianMichael