Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade fs-extra and remove fs-promise #13

Merged
merged 1 commit into from
May 25, 2018

Conversation

Jonahss
Copy link
Contributor

@Jonahss Jonahss commented Nov 19, 2017

When installing, npm warns
npm WARN deprecated fs-promise@2.0.3: Use mz or fs-extra^3.0 with Promise Support

fs-extra was actually already a dependency. I updated it and removed fs-promise.

require('./lib/files.js').test().then(console.log)
// true

@davesag
Copy link

davesag commented Feb 2, 2018

I'd love to see this PR get merged as those deprecation warnings are annoying. Thanks in advance

@Jonahss
Copy link
Contributor Author

Jonahss commented Feb 5, 2018

I checked that the libraries are compatible, so it should be good to go.

@benjamincburns
Copy link

@MaiaVictor - anything blocking getting this merged & released? This package is included as a transitive dependency of web3.js (web3-bzz, specifically), a very popular tool in the ethereum ecosystem. As a result, anyone doing ethereum development today is encountering deprecation warnings when they install packages with this dependency.

I'm happy to help out if anything needs doing before this can be merged, unless of course @Jonahss handles it first!

@evertonfraga evertonfraga merged commit 4954ed0 into VictorTaelin:master May 25, 2018
@Jonahss Jonahss deleted the fs-extra branch May 25, 2018 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants