-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7703 metricsql support metric names in quotes as alternative to name metric pattern #40
7703 metricsql support metric names in quotes as alternative to name metric pattern #40
Conversation
…without a value to specify metric name
Fixed bug with error not reporting because of isPossibleMetric being when a label name was not quoted
Added tests to ensure setting two metric names threw errors
Refactored code checking for quoted strings into isQuoteString Added some additional tests
This reverts commit 41dc7c1.
It would seem
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
A few minor comments
…ic filters Co-authored-by: Roman Khavronenko <roman@victoriametrics.com>
…names - this case will now throw an error and is tested in expected Fail cases
Enhance MetricsQL to support quoted UTF8 label names