Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for topologySpreadConstraints #107

Closed
umezawatakeshi opened this issue Dec 1, 2020 · 3 comments
Closed

Support for topologySpreadConstraints #107

umezawatakeshi opened this issue Dec 1, 2020 · 3 comments
Assignees
@f41gh7
Labels
enhancement New feature or request

Comments

@umezawatakeshi
Copy link
Contributor

I want support for topologySpreadConstraints in CRs that deploy pods. It makes pod scheduling more flexible.

It is already supported in Prometheus Operator.
@f41gh7 f41gh7 added the enhancement New feature or request label Dec 1, 2020
@f41gh7 f41gh7 self-assigned this Dec 1, 2020
f41gh7 added a commit that referenced this issue Dec 2, 2020
@f41gh7
adds topologySpreadConstraints to CRD objects,
b8b8502 
added e2e test recover
#107
@f41gh7 f41gh7 mentioned this issue Dec 2, 2020
Merged
f41gh7 added a commit that referenced this issue Dec 2, 2020
@f41gh7
adds topologySpreadConstraints to CRD objects, (#110)
9f8d138 
* adds topologySpreadConstraints to CRD objects,
added e2e test recover
#107

* Removed uneeded file
@umezawatakeshi
Copy link
Contributor Author

umezawatakeshi commented Dec 3, 2020 •
edited
Loading

I tried the update #110 .

Because the VMCluster CRD becomes much larger, it now hit the problem stated at kubernetes/kubectl#712 .

umezawa@node0:~/release/crds$ kubectl apply -f crd.yaml
customresourcedefinition.apiextensions.k8s.io/vmagents.operator.victoriametrics.com configured
customresourcedefinition.apiextensions.k8s.io/vmalertmanagers.operator.victoriametrics.com configured
customresourcedefinition.apiextensions.k8s.io/vmalerts.operator.victoriametrics.com configured
customresourcedefinition.apiextensions.k8s.io/vmpodscrapes.operator.victoriametrics.com configured
customresourcedefinition.apiextensions.k8s.io/vmprobes.operator.victoriametrics.com configured
customresourcedefinition.apiextensions.k8s.io/vmrules.operator.victoriametrics.com configured
customresourcedefinition.apiextensions.k8s.io/vmservicescrapes.operator.victoriametrics.com configured
customresourcedefinition.apiextensions.k8s.io/vmsingles.operator.victoriametrics.com configured
The CustomResourceDefinition "vmclusters.operator.victoriametrics.com" is invalid: metadata.annotations: Too long: must have at most 262144 bytes

This problem can be avoided by using server-side apply and the procedure written in quick-start.MD might be updated to use kubectl apply --server-apply=true. However, my team uses Argo CD to deploy applications including VictoriaMetrics operator and Argo CD does not support server-side apply yet...

The operator itself seems to be working as expected. Thank you.

@f41gh7
Copy link
Collaborator

f41gh7 commented Dec 3, 2020

Ahhh, get it. Its a common issue with huge crd objects, i'll fix it soon.

But in general need to think about some marker at kubernetes controller-gen, that will skip schema generation for embedded resources.

@umezawatakeshi
Copy link
Contributor Author

I tested v0.5.0. It seems to work fine. Thank you.

@f41gh7 f41gh7 closed this as completed Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@f41gh7 f41gh7

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@umezawatakeshi @f41gh7