Expose observedGeneration at status spec for CRD objects
#1155
Assignees
Labels
enhancement
New feature or request
Comments
f41gh7
added a commit
that referenced
this issue
Nov 20, 2024
Previously, applications had different json tags for `updataStatus` fields. clusterStatus for VMCluster for instance. Print fields for status pointed to the different fields. There were unused fields at status definitions. Code was copy-pasted for status updates. This commit addresses this issue with the following changes: * copy-pasted code replaced with generic implementation * after status patch, operator updates object version. This must resolve issues with conflicts during status update requests. * unused fields marked as deprecated an will be removed at upcoming releases * now all app components uses the same field `updateStatus`, that holds information about current app state * In addition new field `observedGeneration` was added, in the same way as it used at Kubernetes API. This change must help track CRD objects changes for 3rd party clients. Related issue: #1155 Signed-off-by: f41gh7 <nik@victoriametrics.com>
f41gh7
added a commit
that referenced
this issue
Nov 20, 2024
Previously, applications had different json tags for `updataStatus` fields. clusterStatus for VMCluster for instance. Print fields for status pointed to the different fields. There were unused fields at status definitions. Code was copy-pasted for status updates. This commit addresses this issue with the following changes: * copy-pasted code replaced with generic implementation * after status patch, operator updates object version. This must resolve issues with conflicts during status update requests. * unused fields marked as deprecated an will be removed at upcoming releases * now all app components uses the same field `updateStatus`, that holds information about current app state * In addition new field `observedGeneration` was added, in the same way as it used at Kubernetes API. This change must help track CRD objects changes for 3rd party clients. Related issue: #1155 Signed-off-by: f41gh7 <nik@victoriametrics.com>
f41gh7
added
the
waiting for release
|
Issue was partially fixed at v0.50.0 release It's still required to add |
f41gh7
removed
the
waiting for release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently CRDs have
statusandreasonfield which provide object state description. It will be great to also haveobservedGenerationfield asKubernetesdoes for core resources.observedGeneration must be changed to the value of
metadata.generationfield at the time, when operator started to process reconcile event for CRD.See this docs for details https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties
The text was updated successfully, but these errors were encountered: