Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VictoriaMetrics operator should be cgroup aware #875

Closed
uhthomas opened this issue Feb 26, 2024 · 2 comments
Closed

VictoriaMetrics operator should be cgroup aware #875

uhthomas opened this issue Feb 26, 2024 · 2 comments

Comments

@uhthomas
Copy link

uhthomas commented Feb 26, 2024

Go is not cgroup aware. This means the VictoriaMetrics operator will be throttled hard in containerised environments with CPU limits.

The below screenshot shows the container with a CPU limit in Kubernetes. The first half of the time series is on a 13600k, with 20 threads. The second half is when the machine changed to use an EPYC 7763 with 128 threads.

image

automaxprocs can use cgroups automatically.

uhthomas added a commit to uhthomas/vm-operator that referenced this issue Feb 26, 2024
Go is not cgroup aware and by default will set GOMAXPROCS to the number
of available threads, regardless of whether it is within the allocated
quota. This behaviour causes high amount of CPU throttling and degraded
application performance.

Fixes: VictoriaMetrics#875
@Haleygo
Copy link
Contributor

Haleygo commented Feb 27, 2024

Hello @uhthomas , thanks for the issue!
AFAIK the operator code itself doesn't use muti-thread to process resource objects, so I'm not sure the performance benefit here. Did you see some valid results with new GOMAXPROCS?

@f41gh7
Copy link
Collaborator

f41gh7 commented Aug 6, 2024

Hello, thanks for reporting the issue.

Currently, operator doesn't use GOMAXPROCS for paralleling CPU bound tasks. Actually, it doesn't perform any heavy CPU bound operations. And unlikely it will change in the future.

Meanwhile the issue itself looks to me more like golang runtime problem, neither something that each application should fix on it's own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants