Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to select playback speed from a list of values #2771

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

frozenduck
Copy link
Contributor

1953

I had to move the speed selection option up because the screen did not fit all the values in the drop-down list, otherwise everything works fine.

@moisout
Copy link
Member

moisout commented Apr 15, 2024

Thanks a lot for this PR, I'll check it out as soon as i can

@moisout
Copy link
Member

moisout commented Apr 15, 2024

Other than the things I wrote above, it looks good to me!
If you want to, you can format the files with prettier using the config file in the repo, not required tho.

@frozenduck
Copy link
Contributor Author

I fixed the styles and number parsing, probably should be fine now.

@moisout
Copy link
Member

moisout commented Apr 17, 2024

LGTM👍️, thank you!

@moisout moisout merged commit 8c2239a into ViewTube:development Apr 17, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants