Skip to content

Commit

Permalink
Merge pull request ronanguilloux#88 from Soullivaneuh/api-closing
Browse files Browse the repository at this point in the history
API closing
  • Loading branch information
soullivaneuh committed Apr 14, 2016
2 parents d69f6b6 + 5ef5e7d commit d8e5fc8
Show file tree
Hide file tree
Showing 22 changed files with 25 additions and 21 deletions.
4 changes: 4 additions & 0 deletions UPGRADE-2.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

This version need now Symfony 2.7 LTS as a minimum requirement.

## API closing

Constraint and validator classes are now `final` because there is no reason to override them.

## Deprecations

All deprecated code introduced on 1.x are removed on 2.0.
Expand Down
2 changes: 1 addition & 1 deletion src/Constraints/Bban.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*
* @author Sullivan Senechal <soullivaneuh@gmail.com>
*/
class Bban extends IsoCodesGeneric
final class Bban extends IsoCodesGeneric
{
public $message = 'This value is not a valid BBAN.';
}
2 changes: 1 addition & 1 deletion src/Constraints/Cif.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*
* @author Sullivan Senechal <soullivaneuh@gmail.com>
*/
class Cif extends IsoCodesGeneric
final class Cif extends IsoCodesGeneric
{
public $message = 'This value is not a valid CIF.';
}
2 changes: 1 addition & 1 deletion src/Constraints/CreditCard.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*
* @author Sullivan Senechal <soullivaneuh@gmail.com>
*/
class CreditCard extends IsoCodesGeneric
final class CreditCard extends IsoCodesGeneric
{
public $message = 'This value is not a valid credit card scheme.';
}
2 changes: 1 addition & 1 deletion src/Constraints/Ean13.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*
* @author Sullivan Senechal <soullivaneuh@gmail.com>
*/
class Ean13 extends IsoCodesGeneric
final class Ean13 extends IsoCodesGeneric
{
public $message = 'This EAN 13 code is not valid.';
}
2 changes: 1 addition & 1 deletion src/Constraints/Iban.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*
* @author Sullivan Senechal <soullivaneuh@gmail.com>
*/
class Iban extends IsoCodesGeneric
final class Iban extends IsoCodesGeneric
{
public $message = 'This value is not a valid IBAN.';
}
2 changes: 1 addition & 1 deletion src/Constraints/Insee.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*
* @author Sullivan Senechal <soullivaneuh@gmail.com>
*/
class Insee extends IsoCodesGeneric
final class Insee extends IsoCodesGeneric
{
public $message = 'This INSEE number is not valid.';
}
2 changes: 1 addition & 1 deletion src/Constraints/Ip.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
*
* @author Sullivan Senechal <soullivaneuh@gmail.com>
*/
class Ip extends Constraint
final class Ip extends Constraint
{
public $message = 'This value is not a valid IP address.';
}
2 changes: 1 addition & 1 deletion src/Constraints/IpValidator.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
/**
* @author Sullivan Senechal <soullivaneuh@gmail.com>
*/
class IpValidator extends AbstractIsoCodesConstraintValidator
final class IpValidator extends AbstractIsoCodesConstraintValidator
{
/**
* {@inheritdoc}
Expand Down
2 changes: 1 addition & 1 deletion src/Constraints/Isbn.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
*
* @author Sullivan Senechal <soullivaneuh@gmail.com>
*/
class Isbn extends Constraint
final class Isbn extends Constraint
{
public $message = 'This value is not a valid ISBN.';
public $type = null;
Expand Down
2 changes: 1 addition & 1 deletion src/Constraints/IsbnValidator.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
/**
* @author Sullivan Senechal <soullivaneuh@gmail.com>
*/
class IsbnValidator extends AbstractIsoCodesConstraintValidator
final class IsbnValidator extends AbstractIsoCodesConstraintValidator
{
/**
* {@inheritdoc}
Expand Down
2 changes: 1 addition & 1 deletion src/Constraints/Nif.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*
* @author Sullivan Senechal <soullivaneuh@gmail.com>
*/
class Nif extends IsoCodesGeneric
final class Nif extends IsoCodesGeneric
{
public $message = 'This value is not a valid NIF.';
}
2 changes: 1 addition & 1 deletion src/Constraints/Siren.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*
* @author Sullivan Senechal <soullivaneuh@gmail.com>
*/
class Siren extends IsoCodesGeneric
final class Siren extends IsoCodesGeneric
{
public $message = 'This value is not a valid SIREN.';
}
2 changes: 1 addition & 1 deletion src/Constraints/Siret.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*
* @author Sullivan Senechal <soullivaneuh@gmail.com>
*/
class Siret extends IsoCodesGeneric
final class Siret extends IsoCodesGeneric
{
public $message = 'This value is not a valid SIRET.';
}
2 changes: 1 addition & 1 deletion src/Constraints/Ssn.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
*
* @author Sullivan Senechal <soullivaneuh@gmail.com>
*/
class Ssn extends Constraint
final class Ssn extends Constraint
{
public $message = 'This value is not a valid SSN.';
}
2 changes: 1 addition & 1 deletion src/Constraints/SsnValidator.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
/**
* @author Sullivan Senechal <soullivaneuh@gmail.com>
*/
class SsnValidator extends AbstractIsoCodesConstraintValidator
final class SsnValidator extends AbstractIsoCodesConstraintValidator
{
/**
* {@inheritdoc}
Expand Down
2 changes: 1 addition & 1 deletion src/Constraints/StructuredCommunication.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*
* @author Sullivan Senechal <soullivaneuh@gmail.com>
*/
class StructuredCommunication extends IsoCodesGeneric
final class StructuredCommunication extends IsoCodesGeneric
{
public $message = 'This value is not a valid structured communication code.';
}
2 changes: 1 addition & 1 deletion src/Constraints/SwiftBic.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*
* @author Sullivan Senechal <soullivaneuh@gmail.com>
*/
class SwiftBic extends IsoCodesGeneric
final class SwiftBic extends IsoCodesGeneric
{
public $message = 'This value is not a valid SWIFT.';
}
2 changes: 1 addition & 1 deletion src/Constraints/Uknin.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*
* @author Sullivan Senechal <soullivaneuh@gmail.com>
*/
class Uknin extends IsoCodesGeneric
final class Uknin extends IsoCodesGeneric
{
public $message = 'This value is not a valid NINO.';
}
2 changes: 1 addition & 1 deletion src/Constraints/Vat.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*
* @author Sullivan Senechal <soullivaneuh@gmail.com>
*/
class Vat extends IsoCodesGeneric
final class Vat extends IsoCodesGeneric
{
public $message = 'This value is not a valid VAT.';
}
2 changes: 1 addition & 1 deletion src/Constraints/ZipCode.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
*
* @author Sullivan Senechal <soullivaneuh@gmail.com>
*/
class ZipCode extends Constraint
final class ZipCode extends Constraint
{
const ALL = 'all';

Expand Down
2 changes: 1 addition & 1 deletion src/Constraints/ZipCodeValidator.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
/**
* @author Sullivan Senechal <soullivaneuh@gmail.com>
*/
class ZipCodeValidator extends AbstractIsoCodesConstraintValidator
final class ZipCodeValidator extends AbstractIsoCodesConstraintValidator
{
/**
* @param mixed $value
Expand Down

0 comments on commit d8e5fc8

Please sign in to comment.