Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the code to ..routes/reviews.js #345

Closed
wants to merge 2 commits into from

Conversation

shar2710
Copy link

@shar2710 shar2710 commented Oct 29, 2024

📋 Description

Description
Currently, as more reviews are added, the page height increases significantly. This can lead to a poor user experience, especially on smaller screens.

Current Behavior
The reviews section should have a scrollable container that allows users to view all reviews without increasing the overall page height.

Additional Considerations
Consider implementing a mechanism to limit the number of reviews displayed initially and load more on demand using JavaScript.

the code has been incorporated into the ..controllers/reviews.js file

✅ Checklist

Before submitting the PR, please make sure you have completed the following:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings.
  • I have tested it locally and it works fine.
  • Any dependent changes have been merged and published in downstream modules.

🏷️ Types of Changes

What type of changes does your code introduce? (Check all that apply)

  • Bug fix (non-breaking change which fixes an issue) 🐛
  • New feature (non-breaking change which adds functionality) ✨
  • UI enhancement (non-breaking change which enhances UI) 🎨
  • Documentation update 📚

fixes issue #341

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. Support us by ⭐starring our repository!

@shar2710
Copy link
Author

@Vignesh025 i have completed this task. kindly check

@Vignesh025
Copy link
Contributor

Hey @shar2710 I’m getting an error when running your code. Please take a look and resolve it.

image

@shar2710
Copy link
Author

@Vignesh025 i have resolved the error. please check

@Vignesh025
Copy link
Contributor

Vignesh025 commented Oct 31, 2024

@shar2710 , the feature is not working.

image

@Vignesh025 Vignesh025 closed this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants