Enhance Campground Schema with Validation, Timestamps, and Improved Error Logging #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smog-root ,In the new campground form, when the title is less than 3 characters, it throws a 'bad gateway' error. However, in the edit campground form, it correctly shows the error message indicating that the title is too short. Please check and fix this inconsistency. |
When validation errors occur (like the title being too short), users are redirected back to the form with a clear message, preventing any 'bad gateway' errors.
|
@Vignesh025 Done!! |
Vignesh025
reviewed
Nov 5, 2024
Comment on lines
-2
to
-4
| const mongoose = require('mongoose'); | ||
| const Review = require('./review'); // Model for associated reviews | ||
| const Schema = mongoose.Schema; // Extract Schema for easier usage |
|
The issue is still there, it's not resolved. |
|
@Vignesh025 Done!! |
Vignesh025
reviewed
Nov 5, 2024
Comment on lines
2
to
4
| const express = require('express'); | ||
| const router = express.Router(); | ||
| const Campground = require(''./review''); |
There was a problem hiding this comment.
why did you delete these lines?
and the issue we have mentioned is still there.
|
@Vignesh025 I will fix it!! Wait!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #361
Kindly add all the labels and assign me! @Vignesh025
Summary of Changes:
1. Validation Constraints:
minlength: 3fortitle.min: 0forprice.2. Timestamps:
createdAtandupdatedAtfields.3. Enhanced Error Logging:
findOneAndDeletemiddleware to include the campground ID and number of deleted reviews for better debugging.This updated version includes all features requested, making the schema more robust and informative. Let me know if further adjustments are needed!