Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/campground card style #407

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

Remy349
Copy link
Contributor

@Remy349 Remy349 commented Nov 14, 2024

📋 Description

When performing a search using the search bar, the camp cards do not have a good user-friendly design. This only happens in device views larger than 768px. I have decided to make a small fix to the card styles so that the cards maintain their design on both mobile devices and computers.

🔨 Changes Made

  • Remove class on camp card after using the search bar
  • Adding styles to the image to make it responsive

✅ Checklist

Before submitting the PR, please make sure you have completed the following:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings.
  • I have tested it locally and it works fine.
  • Any dependent changes have been merged and published in downstream modules.

🏷️ Types of Changes

What type of changes does your code introduce? (Check all that apply)

  • Bug fix (non-breaking change which fixes an issue) 🐛
  • New feature (non-breaking change which adds functionality) ✨
  • UI enhancement (non-breaking change which enhances UI) 🎨
  • Documentation update 📚

📸 Screenshots (if applicable)

  • Before:

Screenshot_2024-11-14-17-20-24_1366x768

  • After:

Screenshot_2024-11-14-17-21-04_1366x768

Reminder:

Please ensure your pull request is made to the test branch, not main.

Thank you for contributing to VigneshDevHub! We look forward to reviewing your PR and getting it merged!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. Support us by ⭐starring our repository!

@Vignesh025 Vignesh025 merged commit b2bee55 into VigneshDevHub:test Nov 15, 2024
1 check passed
@Vignesh025
Copy link
Contributor

Thankyou for Contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants