Remove [Serializable] from VB types (dotnet#21046)

ViktorHofer · Jun 15, 2017 · b59a500 · b59a500
1 parent 7aeb0c1
commit b59a500
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 39 deletions.
diff --git a/src/Microsoft.VisualBasic/src/Microsoft/VisualBasic/CompilerServices/ExceptionUtils.vb b/src/Microsoft.VisualBasic/src/Microsoft/VisualBasic/CompilerServices/ExceptionUtils.vb
@@ -58,7 +58,6 @@ Namespace Microsoft.VisualBasic.CompilerServices
 
     End Class
 
-    <Serializable()>
     Public NotInheritable Class InternalErrorException
         Inherits System.Exception
 
@@ -75,10 +74,6 @@ Namespace Microsoft.VisualBasic.CompilerServices
             MyBase.New(GetResourceString(SR.InternalError))
         End Sub
 
-        Private Sub New(ByVal info As System.Runtime.Serialization.SerializationInfo, ByVal context As System.Runtime.Serialization.StreamingContext)
-            MyBase.New(info, context)
-        End Sub
-
     End Class
 
 End Namespace
diff --git a/...rosoft.VisualBasic/src/Microsoft/VisualBasic/CompilerServices/IncompleteInitialization.vb b/...rosoft.VisualBasic/src/Microsoft/VisualBasic/CompilerServices/IncompleteInitialization.vb
@@ -5,19 +5,11 @@
 Namespace Global.Microsoft.VisualBasic.CompilerServices
     <Global.System.Diagnostics.DebuggerNonUserCode()>
     <Global.System.ComponentModel.EditorBrowsable(Global.System.ComponentModel.EditorBrowsableState.Never)>
-    <Global.System.Serializable>
     Public Class IncompleteInitialization
         Inherits Global.System.Exception
         Public Sub New()
             MyBase.New()
         End Sub
 
-#Disable Warning CA2229 ' Rule wants ctor to be protected, but private to match desktop
-        <Global.System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Advanced)>
-        Private Sub New(ByVal info As System.Runtime.Serialization.SerializationInfo, ByVal context As System.Runtime.Serialization.StreamingContext)
-            MyBase.New(info, context)
-        End Sub
-#Enable Warning CA2229 ' Implement Serialization constructor
-
     End Class
 End Namespace
diff --git a/src/Microsoft.VisualBasic/src/Microsoft/VisualBasic/CompilerServices/StaticLocalInitFlag.vb b/src/Microsoft.VisualBasic/src/Microsoft/VisualBasic/CompilerServices/StaticLocalInitFlag.vb
@@ -5,7 +5,6 @@
 Namespace Global.Microsoft.VisualBasic.CompilerServices
     <Global.System.Diagnostics.DebuggerNonUserCode()>
     <Global.System.ComponentModel.EditorBrowsable(Global.System.ComponentModel.EditorBrowsableState.Never)>
-    <Global.System.Serializable()>
     Public Class StaticLocalInitFlag
         Public State As Short
     End Class

diff --git a/src/Microsoft.VisualBasic/tests/Microsoft.VisualBasic.Tests.csproj b/src/Microsoft.VisualBasic/tests/Microsoft.VisualBasic.Tests.csproj
@@ -7,7 +7,6 @@
   <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'netstandard-Debug|AnyCPU'" />
   <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'netstandard-Release|AnyCPU'" />
   <ItemGroup>
-    <Compile Include="SerializationTests.cs" />
     <Compile Include="StringsTests.cs" />
     <Compile Include="$(CommonTestPath)\System\PlatformDetection.cs">
       <Link>CommonTest\System\PlatformDetection.cs</Link>
@@ -17,4 +16,4 @@
     </Compile>
   </ItemGroup>
   <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" />
-</Project>
+</Project>
diff --git a/src/Microsoft.VisualBasic/tests/SerializationTests.cs b/src/Microsoft.VisualBasic/tests/SerializationTests.cs