Fix invalid 'implicit scope' report on global or autoload function

```vim function SomeFunc() endfunction function aaa#bbb() endfunction ```
Vimjas · Nov 28, 2015 · 2676a92 · 2676a92
1 parent 18217d7
commit 2676a92
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/vint/ast/plugin/scope_plugin/__init__.py b/vint/ast/plugin/scope_plugin/__init__.py
@@ -14,6 +14,7 @@
 )
 from vint.ast.plugin.scope_plugin.identifier_classifier import (
     is_autoload_identifier as _is_autoload_identifier,
+    is_function_identifier as _is_function_identifier,
 )
 
 
@@ -52,6 +53,9 @@ def is_autoload_identifier(self, node):
         return _is_autoload_identifier(node)
 
 
+    def is_function_identifier(self, node):
+        return _is_function_identifier(node)
+
     def get_objective_scope_visibility(self, node):
         link_registry = self._get_link_registry()
         context_scope = link_registry.get_context_scope_by_identifier(node)

diff --git a/vint/linting/policy/prohibit_implicit_scope_variable.py b/vint/linting/policy/prohibit_implicit_scope_variable.py
@@ -27,7 +27,8 @@ def is_valid(self, identifier, lint_context):
         policy_options = self.get_policy_options(lint_context)
         suppress_autoload = policy_options['suppress_autoload']
 
-        is_valid = (explicity is not ExplicityOfScopeVisibility.IMPLICIT or
+        is_valid = scope_plugin.is_function_identifier(identifier) or (
+                    explicity is not ExplicityOfScopeVisibility.IMPLICIT or
                     is_autoload and suppress_autoload)
 
         if not is_valid: