Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neovim support #157

Merged
merged 5 commits into from
Feb 12, 2016
Merged

Neovim support #157

merged 5 commits into from
Feb 12, 2016

Conversation

Kuniwak
Copy link
Member

@Kuniwak Kuniwak commented Feb 12, 2016

Related #130

@Kuniwak Kuniwak self-assigned this Feb 12, 2016
@RianFuro
Copy link
Contributor

Dang, you beat me to it :D

@Kuniwak
Copy link
Member Author

Kuniwak commented Feb 12, 2016

Oh, I'm sorry!
This achievement would not have been possible without your support.
And I don't know Neovim-specific rules yet, so I always welcome your help.

Thank you very much!

@Kuniwak Kuniwak changed the title [WIP] Neovim support Neovim support Feb 12, 2016
Kuniwak added a commit that referenced this pull request Feb 12, 2016
@Kuniwak Kuniwak merged commit 4fcd842 into master Feb 12, 2016
@Kuniwak Kuniwak deleted the neovim-support branch February 12, 2016 12:18
@Kuniwak Kuniwak added this to the v0.3.6 milestone Feb 12, 2016
@Kuniwak
Copy link
Member Author

Kuniwak commented Feb 12, 2016

This feature shipped with https://github.com/Kuniwak/vint/releases/tag/v0.3.6.
Thank you, @RianFuro ! 🌹

@jrolfs
Copy link

jrolfs commented Apr 2, 2017

Looks like this doesn't cover the non-recursive version of tmap as I'm seeing errors for the following:

" Terminal
tnoremap <ESC><ESC> <C-\><C-n>
tnoremap <D-l> clear<CR>

tmap <C-h> <ESC><ESC><C-h>
tmap <C-j> <ESC><ESC><C-j>
tmap <C-k> <ESC><ESC><C-k>
tmap <C-l> <ESC><ESC><C-l>

tmap-sad

Should I open a PR to add tmap support as well?

@RianFuro
Copy link
Contributor

RianFuro commented Apr 2, 2017

@jrolfs ouch, good catch. No idea how i missed that :/
Basically, we'd need to fix that in vimlparser (https://github.com/ynkdir/vim-vimlparser), but ynkdir seems inactive for almost a year now, so I don't know how much good it'd do us.
@Kuniwak maybe we should opt to resolve it in your local copy instead? (or we could maintain a fork ourselves...)

@jrolfs
Copy link

jrolfs commented Apr 2, 2017

Seems fairly easy to miss as there's quite a few examples (as well as a plugin or two) around for improving Neovim's defaults for terminal mappings and none of them use tmap.

The <ESC><ESC> part of my example is a little contrived, however it's really nice to let <C-l> etc. expand to the standard pane navigation I have defined (i.e: <C-l><C-w><C-l>).

@jrolfs
Copy link

jrolfs commented Apr 2, 2017

@Kuniwak I'll hopefully have time for a PR so let me know what you decide regarding @RianFuro's comment.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants