Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linting autocmd #260

Merged
merged 3 commits into from
Jun 18, 2018
Merged

Fix linting autocmd #260

merged 3 commits into from
Jun 18, 2018

Conversation

ichizok
Copy link
Contributor

@ichizok ichizok commented Jan 13, 2018 •
edited
Loading

  • augroup can ignore case of END

And now vint treats group name which starts with "END" (e.g. augroup ENDing) same as augroup END; it is wrong.

  • autocmd can accept comma-separated list of events (e.g. autocmd BufNewFile,BufRead ...)

Now vint cannot recognize them as event names.

@Kuniwak Kuniwak self-requested a review June 18, 2018 07:32
Kuniwak
Kuniwak approved these changes Jun 18, 2018
View reviewed changes
Copy link
Member

@Kuniwak Kuniwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my too late reply.

Looks good to me. Thank you @ichizok !

@Kuniwak Kuniwak merged commit 172b110 into Vimjas:master Jun 18, 2018
@ichizok ichizok deleted the fix/lint-autocmd branch June 18, 2018 10:37
@Kuniwak Kuniwak mentioned this pull request Jun 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kuniwak Kuniwak Kuniwak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ichizok @Kuniwak