Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkdocs workflow not working on some pull requests #56

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

vincentberenz
Copy link
Collaborator

The bot does not get the permission to push to the gh-pages branch.
Trying to solve this by the use of a personal token.

@vincentberenz vincentberenz added bug Something isn't working documentation Improvements or additions to documentation labels Dec 4, 2023
@vincentberenz vincentberenz self-assigned this Dec 4, 2023
@VincentStimper VincentStimper merged commit df54633 into master Dec 4, 2023
2 checks passed
@vincentberenz vincentberenz deleted the vberenz/mkdocs_token branch December 4, 2023 14:23
@VincentStimper
Copy link
Owner

@vincentberenz unfortunately, this did not fix the problem.

I think the doc deployment only failed because the PR was from somebody how has not been added as a contributor to the repository. When I merged the change, it worked without an error. Hence, we can probably revert this change, since the deployment of the docs is still done with the previous version, although not at the time of the PR. The unit tests still work, which is the more important thing anyway, especially if the document is not touched. What do you think, @vincentberenz?

@vincentberenz
Copy link
Collaborator Author

@VincentStimper Agreed, even more since I removed the workflow on the pull request. I will revert the changes, and push directly to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants