-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sorting of multiple keys and misc #93
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken, because the last index was not actually considered. `i` never reaches `res.len`, only `res.high` hence we need to include it.
Did I seriously manage to bake in bugs into the tests or did I also break something at the same time? Will investigate in the coming days. facepalm: I guess I did. Who decided I get to code this? |
The old bug was that I misunderstood my own logic a few months after writing. Hence the notes now. The problem was just that I didn't realize that `i == df.high` and any other case before that where we want to sort (`last != cur`) are different in terms of the last idx to be sorted.
This happens for instance for a facet wrap, where we don't draw the tick labels on the plots not on the left side (y axis). Then we ended up with a wrong number of elements in the `labs` sequence, which caused a index error when accessing the labs later (it `must` have as many elements as `filterIdx` here)
This only performs a permutation so the user needs to be aware of the correct order of the legend. It's an experimental feature, which will either be rewritten or at least improved on.
Due to the introduction of wrapping of the titles the placement and name of the resulting GraphObjects changes slighlty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly fixes a bug messing up sorting by multiple keys. The last row was not sorted and remained the unsorted last row.
Note to self: should spend more time writing tests...
Full changelog: