Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete migration from GreenDAO to SQLDelight #25

Merged
merged 2 commits into from
Jan 25, 2025

Conversation

papjul
Copy link

@papjul papjul commented Jan 22, 2025

  • Update dependencies and targetSDK to 35
  • Revert the refactoring of the denylist (only ~10% was done and everything else was deleted and not working). I suggest we keep the old (but working!) files, so we can get a release without GreenDAO asap, and refactor denylist later
  • Rename "blacklist" to "denylist" everywhere, as you started doing (+ in French)
  • Use ReQuery SQLite (on top of SQLDelight) to provide a consistent SQLite version across OS versions and devices
  • Fix a few bugs and crashes

Tested:

  • Denylist import
  • Denylist export
  • Denylist add
  • Denylist edit
  • Denylist delete
  • Denylist enable/disable
  • Call blocked when matching a denylist item rule (and denylist enabled)
  • Pattern matching in the call log (correctly match and display the denylist item name)

@papjul papjul force-pushed the refactoring branch 4 times, most recently from 892eecd to a286c5f Compare January 23, 2025 08:04
@papjul papjul changed the title [WIP] Complete migration from GreenDAO to SQLDelight Complete migration from GreenDAO to SQLDelight Jan 23, 2025
@papjul papjul marked this pull request as ready for review January 23, 2025 08:05
@papjul
Copy link
Author

papjul commented Jan 23, 2025

@Vinetos Ready for your review :)

If you already have a debug build installed with the old SQLDelight database schema, you will need to clean your app data first, or it will (probably) crash. This will not happen to the end user, since the latest release is based on GreenDAO, not on your initial SQLDelight schema.

@Vinetos
Copy link
Owner

Vinetos commented Jan 25, 2025

damn, awesome work ! Thanks you so much

@Vinetos Vinetos merged commit 1b809cf into Vinetos:feature/sql_delight Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants