Infinite loop when browsing for cppcheck.exe removed (fixed #182)

VioletGiraffe · Feb 16, 2018 · ce8fb04 · ce8fb04
1 parent f48c2af
commit ce8fb04
Showing 1 changed file with 9 additions and 13 deletions.
diff --git a/CPPCheckPlugin/AnalyzerCppcheck.cs b/CPPCheckPlugin/AnalyzerCppcheck.cs
@@ -59,20 +59,16 @@ public static string cppcheckExePath()
 
 			if (String.IsNullOrEmpty(analyzerPath))
 			{
-				for (; ; )
-				{
-					OpenFileDialog dialog = new OpenFileDialog();
-					dialog.Filter = "cppcheck executable|cppcheck.exe";
-					if (dialog.ShowDialog() != DialogResult.OK)
-						continue;
+				OpenFileDialog dialog = new OpenFileDialog();
+				dialog.Filter = "cppcheck executable|cppcheck.exe";
+				if (dialog.ShowDialog() != DialogResult.OK)
+					return String.Empty;
 
-					analyzerPath = dialog.FileName;
-					if (File.Exists(analyzerPath))
-					{
-						Properties.Settings.Default.CPPcheckPath.Add(analyzerPath);
-						Properties.Settings.Default.Save();
-						break;
-					}
+				analyzerPath = dialog.FileName;
+				if (File.Exists(analyzerPath))
+				{
+					Properties.Settings.Default.CPPcheckPath.Add(analyzerPath);
+					Properties.Settings.Default.Save();
 				}
 			}