-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPPCheckPluginPackage did not load correctly: VS2013 #142
Comments
I believe this edit (replacing 11.0 with 12.0) will break VS 2012 support. Other than that, I don't understand anything here. |
How about using a range for "version" as in this change mkurdej@38c36a6 ? |
As long as it works, feel free to edit everything :) Could you please take a look at the #141 issue? I've lost all ability to work on this project. |
Fix to #142: Plugin did not load correctly in VS2013
@wwarriner @VioletGiraffe |
@SanderBouwhuis : getting a build error, see #141 |
I just hit this error after upgrading from version 1.2.1 to 1.3.1. The error occurs with 1.3 and 1.3.1, but not with 1.2.1. Reverting to 1.2.1 for now. |
@FelixBer: it's fixed already, just need someone to rebuild the .vsix because I can't. |
@FelixBer |
i had the same error as warriner in VS2013 but got up and running with v1.2.1 |
So, the latest release 1.3.1.0 is still not working with Visual Studio 2013. |
@altumano : I'd be happy to, as soon as someone helps me solve the problem with building the project. |
I can build it at work later but my release build is only half the size of previous releases. Were you uploading debug builds or am I missing something in the build process? |
@FelixBer : There's nothing to miss. I don't think I'd upload a debug build, but it's not impossible. |
Yay for FelixBer. |
Here we go: built from 486b159 (edit: pushed version number to 1.3.2) I only tested it very briefly by scanning some projects with cppcheck 1.69 x86 and Visual Studio 2013. Would be great if someone else could test it too. |
I see you didn't increment the version number. That's bad because then you can't update without uninstalling the extension first. |
Fixed. I built from a clean checkout and forgot to bump the version number. I can only send you a pull req for it later though. |
@FelixBer |
That's odd. Did you restart VS? Try going to tools->updates and extensions and uninstall it if its there. Then close down all VS instances and install it again. Then start VS. I just tried it again in various constellations and settings and it works for me. Two questions: Does anything show up in tools->updates and extensions? Does it work with version 1.3.1, the latest official release? I'll only have time to look at this next week. |
CppCheck is in Tools/Extensions and updates. Just to make sure, should there be a new menu for CppCheck in the UI where I can change some settings? Because I don't have that. |
No, there should bee two menu items under the "Tools" menu. Tools -> check current project with cppcheck |
Aaaaah, shoot! Ok, in that case, it works. Mea culpa. |
I've just installed the current version into VS2013 and although the menu entries are there, when clicked they don't do anything. I can run cppcheck fine from the command line though. Any ideas? |
I did have to use nuget to get the shell.11 file though - is it worth changing the shell version to 12 as detailed above or shouldn't that be needed? |
Make sure cppcheck 1.69 x86 is installed. You should also get an error message, either a messagebox or in the output pane or the cppcheck panel. |
|
The same (or similar) is now happening in VS2015, and the change may be more complex. I haven't figured out totally how to fix it, and may not figure it out. There may be changes to dependency structure. |
Maybe we can ask someone from Microsoft? |
We can ask on MSDN forums (https://social.msdn.microsoft.com/Forums/en-US/home?forum=vsx). |
@VioletGiraffe I just uninstalled the plugin, cleared my %Appdata Extension cache, restarted a fresh Visual Studio 2012, then closed it again so that I had a fully clean %Appdata Extension cache. I then ran the 1.3.3 Release installer. The bug is still present in Visual Studio 2012 on this release. If I go through this entire process with bugparty's release, the error message is gone and the plugin works fine. It may be possible that this bug was fixed in 2013, but it still seems very present in 2012. |
That suggests @bugparty didn't commit some of the important changes, IMO. |
oh, I am sure I have commit all the changes,maybe the compiler maters?I am On Fri, Mar 25, 2016 at 2:44 AM, Violet Giraffe notifications@github.com
|
No idea... I used VS2015 to build the release. |
I have both VS2015 and VS2012,I will build two relase later, Maybe We can On Fri, Mar 25, 2016 at 4:26 PM, Violet Giraffe notifications@github.com
|
@VioletGiraffe @bugparty Let me know if you need an additional testing bench as I have been able to reproduce this consistently. |
I checkout the latest master source code and build with vs2012 and 2015 build with vs2015 |
@bugparty |
it works for my vs2012 and vs2013,but I don`t have any settings different On Fri, Apr 15, 2016 at 6:36 PM, Violet Giraffe notifications@github.com
|
Yes, @bugparty version VS2012 and VS2015 works fine on my VS2013 Update 5 (the official version does not work). |
@bugparty @lohengrin It means that you didn't build the latest source. It might also mean there are some uncommited changes on your PC that fix this issue. |
but I just clone a new copy on the master and build it On Fri, Apr 15, 2016 at 8:09 PM, Violet Giraffe notifications@github.com
|
But you can see that my link is correct, and the manifest says 1.3.3, right? Then how come your builds are 1.3.1? |
sorry,I will double check it On Sat, Apr 16, 2016 at 12:32 AM, Violet Giraffe notifications@github.com
|
@bugparty I am also getting the same results as @lohengrin and my builds are listed as version 1.3.1 in my Extension manager. Also oddly enough the plugins are listed as version 1.2.0 if you go to Help->About Microsoft Visual Studio |
@GrenMeera |
Visual studio 2013 update 5 version# 12.0.40629.00. windows 10 pro 64-bit. also VS 2015 is not installed on this machine. |
Finally got it working! I had exact same problem with @christheenchanter. Clone the repo and build it on my machine solved the problem. |
@T-Jin : could you attach your VSIX here so that other people with the same problem can try it out? I wonder if it only works when built on the same machine where it'll be used or not. |
The one built by @bugparty on Mar 18 works on my machine with only VS2013. The official one does not. The official one did work in VS2013 when I had VS2015 installed, though (uninstalled it yesterday, and cppcheck stopped working). Seemingly there's something in bugpartys build that works ;) |
@LinuxdevelopersOrg What about this one? |
@VioletGiraffe Sorry, did not work for me. I cloned and rebuilt this one, and this one works on my machine(tm) (after a rudimentary check-on-save quick test). Edit: Tried my version on my coworkers VS2013 machine and it works there too (his did NOT run with the official client either before). |
@VioletGiraffe Here is my release build. It worked on my win7 64-bit with only VS2013 installed. |
My cppcheckplugin didn't work. I've tried with the build by @T-Jin and now it works. I also have win7 x64 and only VS2013 installed. |
VS 2013 is no longer supported. If you get this error on a newer version of Visual Studio with the latest release, open a new issue. |
The following error occurs while trying to load the plugin following installation:
In the activity log is:
Where I noted the use of
*.Shell.11.0
Going into the extension folder and changing the following entry in "extension.vsixmanifest"
manually to replace 11.0 with 12.0 causes the plugin to work fine.
After downloading and poking around the project, and around the internet, I've discovered what I believe to be related to the issue:
Using CTRL+SHIFT+F, and searching for "11.0" yields
Replacing those instances of 11.0 with 12.0, building, and installing the build also resolves the issue for me.
I don't know nearly enough about C# or the VS SDK, but I also found: github.com and stackoverflow.com which may be relevant to fixing the issue in a robust fashion.
The text was updated successfully, but these errors were encountered: