Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

could not find .SRCINFO file in archive from container #8

Closed
dumbasPL opened this issue Jul 26, 2024 · 5 comments
Closed

could not find .SRCINFO file in archive from container #8

dumbasPL opened this issue Jul 26, 2024 · 5 comments

Comments

@dumbasPL
Copy link

I'm getting

status:  fatal on publishing repository
message: could not find .SRCINFO file in archive from container

on some packages, removing and re-adding them seem to fix it temporarily

I've confirmed that /app/sources/<package name> has a .SRCINFO file and they build fine afterwards

@VirtCode
Copy link
Owner

yep, this is a result of building with an outdated container image, because I made some breaking changes in cd53315, before it was just taking the built version from the container, but now it is taking the whole srcinfo (to account for pkgrel changes).

anyway, this is easily fixable by rebuilding the failing packages with --clean which recreates the container (with the newly pulled image), so

serene build -c your-package

should fix it for that package.

Sorry, should've probably announced the breaking changes somehow, but that's kinda difficult without creating a new release.

@dumbasPL
Copy link
Author

How about doing a clean build when the base container image changes? Or at least versioning the images so that you can bump a major version every time there is a breaking change and force a clean build on all packages using the old image.

@VirtCode
Copy link
Owner

True that would be a better idea, to somehow version the container images and comparing the version to the running server and recreating them if necessary. Will look into that before I push breaking changes next time.

I also should figure out some versioning strategy in general, at the moment it's a bit of a mess.

VirtCode added a commit that referenced this issue Sep 11, 2024
@VirtCode
Copy link
Owner

VirtCode commented Sep 11, 2024

okay, i finally had some time on my hands and have now implemented a versioning strategy for this repo. This bring the following changes:

  • a new tag will be created (by me) every time breaking changes are introduced between the cli, server, or runner
  • the runner images are tagged with edge-{version}
  • the server will make sure containers use the latest runner image tag
  • the cli checks for server version conflicts on list and info, and prints a warning to tell the user to update

This means stuff like this should no longer happen in the future, as the server will recreate the containers if needed. If you have set a runner image via an env, you should update this env to the new format (or just remove it if you are using the images from this repo's gh actions anyways)

Thanks again for bringing this to my attention. This has finally pushed me to do proper versioning. The next bigger thing I will be working on will finally be automatic dependency resolving.

Also (if you are still using this anyways), these changes also add a new command serene manage info, with which you can have a look at some of your server's stats.

@dumbasPL
Copy link
Author

dumbasPL commented Sep 11, 2024

if you are still using this anyways

Yes, I've been dreaming of something like this for ages and almost started making my own at some point. I think the star counter is missing a few zeros if you ask me. Thanks for taking it seriously.

My next adventure will probably involve signing the packages with a hardware key, I'll probably have to add support for that myself though so expect a PR in the near or not-so-near (I'm lazy LOL) future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants