Module CI #27

Annotations

3 errors and 10 warnings

Cloning into '/home/runner/work/vc-module-avatax/vc-module-avatax/artifacts/vc-modules'...

To https://github.com/VirtoCommerce/vc-modules.git

bdf50520..9a289a41 HEAD -> master

/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/ModuleConstants.cs(86,73): warning S2365: Refactor 'AllSettings' into a method, properties should not copy collections. (https://rules.sonarsource.com/csharp/RSPEC-2365) [/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/VirtoCommerce.AvalaraTaxModule.Core.csproj]

/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/ModuleConstants.cs(32,62): warning S3218: Rename this property to not shadow the outer class' member with the same name. (https://rules.sonarsource.com/csharp/RSPEC-3218) [/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/VirtoCommerce.AvalaraTaxModule.Core.csproj]

/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/ModuleConstants.cs(19,49): warning S1104: Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104) [/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/VirtoCommerce.AvalaraTaxModule.Core.csproj]

/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/ModuleConstants.cs(13,49): warning S1104: Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104) [/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/VirtoCommerce.AvalaraTaxModule.Core.csproj]

/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/ModuleConstants.cs(13,49): warning S2223: Change the visibility of 'CompanyCode' or make it 'const' or 'readonly'. (https://rules.sonarsource.com/csharp/RSPEC-2223) [/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/VirtoCommerce.AvalaraTaxModule.Core.csproj]

/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/ModuleConstants.cs(19,49): warning S2223: Change the visibility of 'ServiceUrl' or make it 'const' or 'readonly'. (https://rules.sonarsource.com/csharp/RSPEC-2223) [/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/VirtoCommerce.AvalaraTaxModule.Core.csproj]

/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/ModuleConstants.cs(25,49): warning S1104: Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104) [/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/VirtoCommerce.AvalaraTaxModule.Core.csproj]

/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/ModuleConstants.cs(25,49): warning S2223: Change the visibility of 'AdminAreaUrl' or make it 'const' or 'readonly'. (https://rules.sonarsource.com/csharp/RSPEC-2223) [/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/VirtoCommerce.AvalaraTaxModule.Core.csproj]

/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/ModuleConstants.cs(72,62): warning S3218: Rename this property to not shadow the outer class' member with the same name. (https://rules.sonarsource.com/csharp/RSPEC-3218) [/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/VirtoCommerce.AvalaraTaxModule.Core.csproj]

/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/ModuleConstants.cs(94,31): warning S2386: Use an immutable collection or reduce the accessibility of the public static field 'AllPermissions'. (https://rules.sonarsource.com/csharp/RSPEC-2386) [/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/VirtoCommerce.AvalaraTaxModule.Core.csproj]

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Module CI #27

ci

Module CI #27

Jobs

Run details

Annotations

The logs for this run have expired and are no longer available.

Re-running jobs...