Skip to content

PT-14740: Update to net8 #28

PT-14740: Update to net8

PT-14740: Update to net8 #28

Triggered via pull request December 12, 2023 09:18
Status Success
Total duration 2m 6s
Artifacts

module-ci.yml

on: pull_request
module-katalon-tests  /  e2e-tests
module-katalon-tests / e2e-tests
Matrix: deploy-cloud / Deploy
Waiting for pending jobs
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
ci
/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/ModuleConstants.cs(86,73): warning S2365: Refactor 'AllSettings' into a method, properties should not copy collections. (https://rules.sonarsource.com/csharp/RSPEC-2365) [/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/VirtoCommerce.AvalaraTaxModule.Core.csproj]
ci
/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/ModuleConstants.cs(32,62): warning S3218: Rename this property to not shadow the outer class' member with the same name. (https://rules.sonarsource.com/csharp/RSPEC-3218) [/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/VirtoCommerce.AvalaraTaxModule.Core.csproj]
ci
/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/ModuleConstants.cs(72,62): warning S3218: Rename this property to not shadow the outer class' member with the same name. (https://rules.sonarsource.com/csharp/RSPEC-3218) [/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/VirtoCommerce.AvalaraTaxModule.Core.csproj]
ci
/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/ModuleConstants.cs(13,49): warning S1104: Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104) [/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/VirtoCommerce.AvalaraTaxModule.Core.csproj]
ci
/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/ModuleConstants.cs(25,49): warning S1104: Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104) [/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/VirtoCommerce.AvalaraTaxModule.Core.csproj]
ci
/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/ModuleConstants.cs(19,49): warning S1104: Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104) [/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/VirtoCommerce.AvalaraTaxModule.Core.csproj]
ci
/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/ModuleConstants.cs(19,49): warning S2223: Change the visibility of 'ServiceUrl' or make it 'const' or 'readonly'. (https://rules.sonarsource.com/csharp/RSPEC-2223) [/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/VirtoCommerce.AvalaraTaxModule.Core.csproj]
ci
/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/ModuleConstants.cs(25,49): warning S2223: Change the visibility of 'AdminAreaUrl' or make it 'const' or 'readonly'. (https://rules.sonarsource.com/csharp/RSPEC-2223) [/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/VirtoCommerce.AvalaraTaxModule.Core.csproj]
ci
/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/ModuleConstants.cs(13,49): warning S2223: Change the visibility of 'CompanyCode' or make it 'const' or 'readonly'. (https://rules.sonarsource.com/csharp/RSPEC-2223) [/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/VirtoCommerce.AvalaraTaxModule.Core.csproj]
ci
/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/ModuleConstants.cs(94,31): warning S2386: Use an immutable collection or reduce the accessibility of the public static field 'AllPermissions'. (https://rules.sonarsource.com/csharp/RSPEC-2386) [/home/runner/work/vc-module-avatax/vc-module-avatax/src/AvaTax.TaxModule.Core/VirtoCommerce.AvalaraTaxModule.Core.csproj]