Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KLD: Updated membercard from max-width to set width #58

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

kldickenson
Copy link
Contributor

Linked Issue

#41 - Layout issue with members with smaller github profile photos

Description

Updated src/assets/css/scss/ _members.scss

  • Changed max-width to width:50% for desktop
  • Added width: 100% to mobile as a precaution, though not needed.

Methodology

With a fixed width, a membercard will take up the full desired width instead of determining its width by its contents. This allows for the image to be a standard size and the social media to go all the way to the right edge.

@netlify
Copy link

netlify bot commented Oct 18, 2020

Deploy preview for virtual-coffee-io processing.

Building with commit acaede4

https://app.netlify.com/sites/virtual-coffee-io/deploys/5f8c9e9bbaa0650007c5b1f4

@danieltott danieltott linked an issue Oct 19, 2020 that may be closed by this pull request
@danieltott danieltott merged commit f4dda5d into Virtual-Coffee:main Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout issue with members with smaller github profile photos
2 participants