-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/165 increase the spectral range for major chromophores #166
Feature/165 increase the spectral range for major chromophores #166
Conversation
-Existing H2O spectral data was replaced by https://omlc.org/spectra/water/data/pope97.txt and https://omlc.org/spectra/water/data/kou93b.txt |
Fat spectral data range was extended from 600nm-1000nm to 400nm-1600nm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. @janakarana, thank you for figuring this all out!
I think there was some discussion about updating Spectral Panel references?
hayakawa16, Hb,HbO2: H2O: Fat: Melanin (Skin): Nigrosin: |
Looks great! |
Excellent :) |
Hi @janakarana, I am getting 12 failing unit tests when I pull the code locally. I thought we had this check in the action checks but it appears that it only runs the tests to get code coverage and if they fail it doesn't fail. I will fix that separately but if you could fix those unit tests, that would be great. Thanks! |
Let me fix it. |
…r-major-chromophores
@janakarana I'm not sure why and it could be unrelated but since we added the action to build on all 3 platforms, it looks like the tests are failing on Mac on your branch. Since you have a Mac, are you able to run the unit tests there? |
@lmalenfant, I will check |
All unit tests are passing on my Mac. |
Update versions
Change target solution file
remove Ubuntu and Mac platforms
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the Ubuntu and Mac build & test for now until we can troubleshoot.
This post is just for informational purposes. On linux:
|
Spectral data of the spectral panel had a limited range. The following changes were made to HbO2, Hb, H2O, Fat and Melanin spectral data.
-Hb and HbO2 spectral data ranges were extended from 250nm-1000 nm to 250nm-1600 nm
-Existing H2O spectral data by two sources was replaced by a single source (https://omlc.org/spectra/water/data/segelstein81.txt). This data overlaps with many H2O data.
-Fat spectral data range was extended from 600nm-1000nm to 429nm-1600nm.
-Melanin spectral data range was extended from 600nm-1000nm to 250nm-1600nm.
Many unit tests used the optical properties of liver. As water and fat spectra were slightly different, decimal places of the unit test were corrected accordingly.