Bug/173 monte carlo inverse code fixes #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wavelengths. Found major bug in that get_optical_properties returns [mua,mus',g,n] and I was using the 2nd parameter as if it was mus not musp, so code that substitutes into the infiles for the database generation and the post-processing, inserted the wrong values for "s1" (mus) and "sp1" (musp). This code was correct in the Linux version, however I plan to make sure those results agree with those generated on Windows.
…y added spectral ranges. I updated get_mua.m accordingly to obtain the spectra correctly from the xlsx file. I cleaned up comments in mc_inverse.m and mc_inverse_Win.m so that they align as far as comments go. I took screenshots of the plots for Examples 1-3 in preparation for adding them to the MC Inverse wiki. Now to pull code to Linux and see if I obtain same plots.
…e. This meant changing access into data read. This all started because Linux wasn't reading table correctly.
…affect inversion solution, just affected output at end.
|
janakarana
approved these changes
Sep 24, 2024
|
Thanks for your review @janakarana!! |
|
I added sample output plots to the wiki page: |
parsanam92
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is ready for review. Please see issues page for more description of what was changed.