Add support for configuration #27
Conversation
azdrojowa123
force-pushed
the
configuration-support
branch
2 times, most recently
from
95eccb3 to
da18eef
Compare
.bazel-steward.conf
Outdated
| @@ -0,0 +1,16 @@ | |||
| maven: | |||
There was a problem hiding this comment.
I am guessing that this is some example file?
Shouldn't we just put it in some test resources and validate if it is used correctly?
There was a problem hiding this comment.
I forgot about the tests so I will create them
| @@ -1,5 +1,6 @@ | |||
| package org.virtuslab.bazelsteward.app | |||
|
|
|||
| import config.src.main.kotlin.org.virtuslab.bazelsteward.config.BazelStewardConfiguration | |||
There was a problem hiding this comment.
something bad happened in terms of imports
|
|
||
| private val configFilePath = repoRoot.resolve(".bazel-steward.conf") | ||
|
|
||
| suspend fun get(): Configuration? { |
There was a problem hiding this comment.
It is nullable. Is there any point for getting null from here?
If there is no file, return empty configuration and if there are errors, throw.
| import java.nio.file.Path | ||
|
|
||
| data class Configuration( | ||
| val maven: MavenConfig? |
There was a problem hiding this comment.
I'd avoid nullability in most places if there is a natural way to have something empty, i.e. just have
val maven: MavenConfig = MavenConfig()
val ruledDependencies: List<MavenDependency> = emptyList()
It will be easier to use it in code later
| runCatching { | ||
| Files.newBufferedReader(configFilePath).use { bufferedReader -> | ||
| val configContent = | ||
| bufferedReader.use { br -> br.readLines().filterNot { it.startsWith("#") }.joinToString("\n") } |
There was a problem hiding this comment.
doesn't yaml support comments natively?
There was a problem hiding this comment.
unfortunately not, commented lines are loaded
|
|
||
| class BazelStewardConfiguration(repoRoot: Path) { | ||
|
|
||
| private val configFilePath = repoRoot.resolve(".bazel-steward.conf") |
There was a problem hiding this comment.
I think that later we will have a number of places where we look for it, we might also have various extensions, but now maybe let's look for .bazel-steward.yaml for clarity? .conf may be associated with different formats.
azdrojowa123
force-pushed
the
configuration-support
branch
6 times, most recently
from
b01b3c5 to
5d30768
Compare
| suspend fun get(): Configuration { | ||
|
|
||
| return withContext(Dispatchers.IO) { | ||
| val schemaContent = javaClass.classLoader.getResource("bazel-steward-schema.json")?.readText() ?: return@withContext Configuration() |
There was a problem hiding this comment.
This is rather a serious error in our deployment if we cannot access our schema to validate the config. I'd rather throw here.
lukaszwawrzyk
force-pushed
the
configuration-support
branch
from
1c72d30 to
12b1b03
Compare
No description provided.