Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProviderArgsEncoder does not preserve "secretness" #390

Closed
pawelprazak opened this issue Feb 14, 2024 · 1 comment · Fixed by #414
Closed

ProviderArgsEncoder does not preserve "secretness" #390

pawelprazak opened this issue Feb 14, 2024 · 1 comment · Fixed by #414
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec P1 Bugs severe enough to be the next item assigned to an engineer
Milestone

Comments

@pawelprazak
Copy link
Contributor

This test fails:

test("encode secret ProviderArgs".ignore) {
    given Context = DummyContext().unsafeRunSync()
    val pae       = summon[ProviderArgsEncoder[ProviderArgs]]

    val args         = ProviderArgs(kubeconfig = Output.secret("abcd"))
    val (_, encoded) = pae.encode(args, _ => false).unsafeRunSync()

    val expected = Map("kubeconfig" -> "abcd".asValue.asSecret).asValue

    assertNoDiff(pprint(encoded.asValue).plainText, pprint(expected).plainText)
    assertEqualsValue(encoded.asValue, expected)
  }

The secret was not preserved.

@pawelprazak pawelprazak added kind/bug Some behavior is incorrect or out of spec P1 Bugs severe enough to be the next item assigned to an engineer labels Feb 14, 2024
@pawelprazak pawelprazak modified the milestones: 0.2.1, 0.3.0 Feb 14, 2024
@pawelprazak
Copy link
Contributor Author

fixed by #414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec P1 Bugs severe enough to be the next item assigned to an engineer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant