Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New refied output serde #414

Merged
merged 10 commits into from
Mar 27, 2024
Merged

New refied output serde #414

merged 10 commits into from
Mar 27, 2024

Conversation

pawelprazak
Copy link
Contributor

@pawelprazak pawelprazak commented Mar 8, 2024 •
edited
Loading

fixes #408
fixes #390

@pawelprazak pawelprazak added this to the 0.3.0 milestone Mar 8, 2024
@pawelprazak pawelprazak added kind/cleanup Resolving TODO/FIXME/HACK and other technical debt area/core The SDK's core code impact/no-changelog-required This issue doesn't require a CHANGELOG update labels Mar 8, 2024
@pawelprazak pawelprazak force-pushed the pprazak/refactor-for-new-serde branch from 03a4df2 to 2fbb9fb Compare March 8, 2024 09:44
@pawelprazak pawelprazak force-pushed the pprazak/refactor-for-new-serde branch from a34124d to ebd37f8 Compare March 8, 2024 11:21
@pawelprazak pawelprazak requested a review from lbialy March 12, 2024 13:46
@pawelprazak pawelprazak changed the title Refactor for new serde New refied output serde Mar 12, 2024
@pawelprazak pawelprazak force-pushed the pprazak/refactor-for-new-serde branch 9 times, most recently from aeeaf1e to 5149e70 Compare March 14, 2024 15:16
@pawelprazak
Fix #408 - reified output value codec
2c0effe 
- add support for serialization and deserialization of Output with full OutputData metadata
@pawelprazak pawelprazak force-pushed the pprazak/refactor-for-new-serde branch 6 times, most recently from e356d10 to 1ca0986 Compare March 19, 2024 10:08
@pawelprazak pawelprazak force-pushed the pprazak/refactor-for-new-serde branch 6 times, most recently from 18c9f91 to 9c3b9f2 Compare March 20, 2024 14:02
@pawelprazak pawelprazak mentioned this pull request Mar 20, 2024
Closed
@pawelprazak
Fix #408 - reified output value codec
4668012 
- add support for serialization and deserialization of Output with full OutputData metadata
@pawelprazak pawelprazak force-pushed the pprazak/refactor-for-new-serde branch from 9c3b9f2 to 4668012 Compare March 24, 2024 12:09
lbialy
lbialy requested changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@lbialy lbialy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things need fixing, Array of Struct is the most grave.

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
core/src/main/scala/besom/internal/ProtobufUtil.scala Show resolved Hide resolved
core/src/main/scala/besom/internal/codecs.scala Outdated Show resolved Hide resolved
core/src/main/scala/besom/internal/codecs.scala Show resolved Hide resolved
core/src/main/scala/besom/internal/codecs.scala Show resolved Hide resolved
core/src/main/scala/besom/internal/codecs.scala Outdated Show resolved Hide resolved
core/src/main/scala/besom/internal/codecs.scala Outdated Show resolved Hide resolved
core/src/main/scala/besom/internal/codecs.scala Show resolved Hide resolved
core/src/main/scala/besom/internal/codecs.scala Show resolved Hide resolved
@pawelprazak
Copy link
Contributor Author

Thank you for the review, I've addressed the comments. Ready for re-review.

@pawelprazak pawelprazak requested a review from lbialy March 27, 2024 08:58
@pawelprazak pawelprazak marked this pull request as ready for review March 27, 2024 08:58
pawelprazak
pawelprazak commented Mar 27, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@pawelprazak pawelprazak merged commit a83e3fb into main Mar 27, 2024
2 checks passed
@pawelprazak pawelprazak deleted the pprazak/refactor-for-new-serde branch March 27, 2024 10:06
@pawelprazak pawelprazak mentioned this pull request Apr 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbialy lbialy lbialy approved these changes

Assignees
No one assigned
Labels
area/core The SDK's core code impact/no-changelog-required This issue doesn't require a CHANGELOG update kind/cleanup Resolving TODO/FIXME/HACK and other technical debt
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Port new output serializer form upstream ProviderArgsEncoder does not preserve "secretness"
2 participants
@pawelprazak @lbialy