Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set assumedEvictionErrorLevel to Level.Error #487

Closed
jchapuis opened this issue May 6, 2024 · 9 comments
Closed

Set assumedEvictionErrorLevel to Level.Error #487

jchapuis opened this issue May 6, 2024 · 9 comments
Assignees
Labels
area/core The SDK's core code needs-triage Needs attention from the triage team P1 Bugs severe enough to be the next item assigned to an engineer

Comments

@jchapuis
Copy link

jchapuis commented May 6, 2024

There is an intrinsic eviction warning in the latest build of besom-core with com.lihaoyi:sourcecode . pprint depends on 0.2.7 while besom-core depends on 0.3.1.

Setting assumedEvictionErrorLevel := Level.Error should help in surfacing these issues.

@pawelprazak pawelprazak added needs-triage Needs attention from the triage team area/core The SDK's core code labels May 6, 2024
@lbialy
Copy link
Collaborator

lbialy commented May 7, 2024

Interesting. We use scala-cli to build the whole thing and it didn't catch it, apparently.

@jchapuis
Copy link
Author

jchapuis commented May 8, 2024

Yes so this is actually quite problematic for us as we are using sbt with strict eviction avoidance. Because of this intrinsic compatibility issue in the library, in all projects using besom we have to add libraryDependencySchemes += "com.lihaoyi" %% "sourcecode" % "always"

@lbialy
Copy link
Collaborator

lbialy commented May 8, 2024

Would a quickfix release of 0.3.2 with correct dependency tree help?

@lbialy
Copy link
Collaborator

lbialy commented May 8, 2024

@Gedochao are you aware if scala-cli has any way to prevent eviction-related issues like this? Docs are silent on this topic.

@lbialy lbialy added the P1 Bugs severe enough to be the next item assigned to an engineer label May 10, 2024
@jchapuis
Copy link
Author

@lbialy maybe I should have answered directly, yes a quickfix release would help as right now this libraryDependencySchemes is propagating throughout our repos 🙂

@lbialy
Copy link
Collaborator

lbialy commented May 23, 2024

For reference: the only way to validate this, for now, is to use scala-cli export . --sbt in core and then sbt evicted in dest directory. This shows possible versioning problems. I have fixed them manually in #500.

lbialy added a commit that referenced this issue May 24, 2024
* bumped versions of libraries in core to solve #487
@lbialy lbialy self-assigned this May 24, 2024
@lbialy
Copy link
Collaborator

lbialy commented May 24, 2024

fixed in #500, will release 0.3.2 momentarily

@lbialy lbialy closed this as completed May 24, 2024
@lbialy
Copy link
Collaborator

lbialy commented Jun 10, 2024

@jchapuis I have released 0.3.2-SNAPSHOT (sonatype snapshot repo) today, could you please verify that it solves this issue for you? I will release complete 0.3.2 version once you confirm it does indeed solve your issues.

@jchapuis
Copy link
Author

@lbialy thanks! I can confirm it works 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core The SDK's core code needs-triage Needs attention from the triage team P1 Bugs severe enough to be the next item assigned to an engineer
Projects
None yet
Development

No branches or pull requests

3 participants