Towards Auto API #336

pawelprazak · 2023-12-20T15:22:54Z

Part of #254

Goal: 90% of MVP

The scope:

internal sync implementation with ~90% feature coverage

Out of scope:

RemoteWorkspace implementation
async implementation
inline programs (work in progress, but not complete)
missing GetPermalink implementation
missing event streams / log file streaming / tailer exposed to the user
missing progress / error stream / unix pipe streams exposed to the user
using custom execution context for the language server and shell
fix serialization issues in yaml and json
no logger

API surface missing, notable details:

  /** Allows specifying one or more Writers to redirect incremental preview stdout
    */
  case class ProgressStreams(writers: os.ProcessOutput*) extends PreviewOption

  /** Allows specifying one or more Writers to redirect incremental preview stderr
    */
  case class ErrorProgressStreams(writers: os.ProcessOutput*) extends PreviewOption

  /** Allows specifying one or more channels to receive the Pulumi event stream
    */
  case class EventStreams(channels: EngineEvent*) extends PreviewOption

pawelprazak · 2024-05-16T18:22:47Z

auto/src/main/scala/besom/auto/internal/shell.scala

+      )
+    )(_ => block).toEither.left.map(AutoError("Failed to watch a path", _))
+
+  case class Tailer2(path: os.Path, onLine: String => Unit):


FIXME: attempt two at writing a tailer

pawelprazak · 2024-05-16T18:23:11Z

auto/src/main/scala/besom/auto/internal/shell.scala

+
+  end pulumi
+
+  object Tailer:


FIXME: attempt one at creating a tailer

pawelprazak · 2024-05-16T18:24:58Z

auto/src/main/scala/besom/model/FullyQualifiedStackName.scala

+  *
+  * For self-managed backends, the `org` portion of the stack name must always be the constant value `organization`.
+  */
+opaque type StackName <: String = String


this could probably be reused in core in stack references

pawelprazak · 2024-05-16T18:25:30Z

auto/src/main/scala/besom/model/FullyQualifiedStackName.scala

+  *
+  * See: https://github.com/pulumi/pulumi/issues/2522
+  */
+opaque type FullyQualifiedStackName <: StackName = StackName


this could probably be reused in core in stack references

pawelprazak · 2024-05-16T18:26:45Z

auto/src/main/scala/besom/model/Names.scala

+import scala.language.implicitConversions
+
+/** Name is an identifier. */
+opaque type Name <: String = String


this could probably be useful in core and codegen, but would require a separate module, just for model stuff

pawelprazak · 2024-05-16T18:27:24Z

auto/src/main/scala/besom/model/SemanticVersion.scala

+package besom.model
+
+// TODO: move to separate module
+// NOTICE: keep in sync with codegen/src/model/SemanticVersion.scala


as we don't have a separate model module this was duplicated

besom-cats/src/main/scala/runtime.scala

besom-json/src/main/scala/besom/json/ProductFormats.scala

pawelprazak · 2024-05-16T18:31:36Z

auto/src/main/scala/besom/internal/HackedSerializer.scala

+import org.virtuslab.yaml.internal.load.parse.EventKind._
+import org.virtuslab.yaml.internal.dump.serialize.Serializer
+
+object HackedSerializerImpl extends Serializer {


FIXME: this needs to be fixed upstream

pawelprazak · 2024-05-16T18:32:21Z

auto/src/main/scala/besom/internal/HackedSerializer.scala

+
+  private def convertMappingNode(node: Node.MappingNode): Seq[EventKind] = {
+    val events = node.mappings.toSeq.flatMap {
+      case (_, Node.ScalarNode(null, _))             => Seq.empty


this is the actual change AFAIR, handling null's

pawelprazak · 2024-05-16T18:33:43Z

core/project.scala

@@ -1,6 +1,6 @@
 //> using scala "3.3.1"
 //> using options "-java-output-version:11", "-Ysafe-init", "-Xmax-inlines:64"
-//> using options "-Werror", "-Wunused:all", "-deprecation", "-feature"
+//> using options "-Werror", "-Wunused:all", "-deprecation", "-feature", "-Wconf:cat=deprecation:i"


the magic Wconf ignores deprecation warnings from protobuf so the Werror does not blow up

pawelprazak · 2024-05-16T18:33:56Z

core/src/main/scala/besom/internal/Env.scala

@@ -56,11 +56,6 @@ object Env:
  private[internal] def getConfigSecretKeys(key: String): Try[Set[NonEmptyString]] =
    Try { sys.env.get(key).map(_.parseJson.convertTo[Set[NonEmptyString]]).getOrElse(Set.empty) }

-  private[internal] def isTruthy(s: String): Boolean =


moved to util for reuse

lbialy

lgtm fn

This reverts commit bffe990.

pawelprazak added impact/broken Something that is difficult or impossible for some people to use kind/missing We are missing a part of functionality compared to upstream area/automation-api The Automation API labels Dec 20, 2023

pawelprazak force-pushed the pprazak/towards-auto-api branch 2 times, most recently from b0395f0 to b6cd805 Compare December 21, 2023 09:44

pawelprazak requested a review from lbialy December 21, 2023 09:44

pawelprazak force-pushed the pprazak/towards-auto-api branch 2 times, most recently from 5233c56 to 9d83209 Compare December 27, 2023 11:20

pawelprazak changed the title ~~Towards auto api~~ Towards Auto API Dec 27, 2023

pawelprazak mentioned this pull request Jan 17, 2024

Redesign ResourceOptions family #307

Closed

pawelprazak added this to the 0.3.0 milestone Jan 26, 2024

pawelprazak force-pushed the pprazak/towards-auto-api branch 4 times, most recently from d09c590 to 9d85da6 Compare February 14, 2024 14:32

pawelprazak modified the milestones: 0.3.0, 1.0.0 Feb 22, 2024

pawelprazak added 8 commits May 15, 2024 13:06

Add auto module

5aac1b6

Add auto module

93a5c45

Add Pulumi gRPC language service

0ccacd7

Add language runtime service

e4ed6a5

Re-sync SemanticVersion

6fe02d5

Add more core utils

d6af9f6

Add auto module

b3df2cd

Add non-throwing apis to json

257b598

pawelprazak force-pushed the pprazak/towards-auto-api branch from 9d85da6 to aa6dab0 Compare May 16, 2024 18:19

pawelprazak commented May 16, 2024

View reviewed changes

besom-cats/src/main/scala/runtime.scala Outdated Show resolved Hide resolved

pawelprazak commented May 16, 2024

View reviewed changes

besom-json/src/main/scala/besom/json/ProductFormats.scala Outdated Show resolved Hide resolved

pawelprazak changed the base branch from develop to main May 16, 2024 18:30

pawelprazak commented May 16, 2024

View reviewed changes

pawelprazak force-pushed the pprazak/towards-auto-api branch 2 times, most recently from 83d645d to d2e9941 Compare May 17, 2024 07:43

pawelprazak modified the milestones: 1.0.0, 0.4.0 May 17, 2024

Add auto module

1de6d41

pawelprazak force-pushed the pprazak/towards-auto-api branch from d2e9941 to 1de6d41 Compare May 17, 2024 08:46

pawelprazak and others added 3 commits May 17, 2024 11:32

Add auto module

631974c

Add auto module

1c317ba

added new tailer, some small cleanup

7a68749

lbialy approved these changes May 22, 2024

View reviewed changes

lbialy marked this pull request as ready for review May 22, 2024 10:11

increase timeout on CI

bffe990

lbialy requested a review from prolativ as a code owner May 22, 2024 11:36

lbialy added 2 commits May 22, 2024 13:41

Revert "increase timeout on CI"

8122fdf

This reverts commit bffe990.

bump pulumi version in CI

e5be5b1

lbialy merged commit 7161a94 into main May 22, 2024
2 checks passed

lbialy deleted the pprazak/towards-auto-api branch May 22, 2024 12:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Towards Auto API #336

Towards Auto API #336

pawelprazak commented Dec 20, 2023 •

edited

Loading

pawelprazak May 16, 2024

pawelprazak May 16, 2024

pawelprazak May 16, 2024 •

edited

Loading

pawelprazak May 16, 2024

pawelprazak May 16, 2024

pawelprazak May 16, 2024

pawelprazak May 16, 2024

pawelprazak May 16, 2024

pawelprazak May 16, 2024

pawelprazak May 16, 2024

lbialy left a comment

Towards Auto API #336

Towards Auto API #336

Conversation

pawelprazak commented Dec 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pawelprazak May 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lbialy left a comment

Choose a reason for hiding this comment

pawelprazak commented Dec 20, 2023 •

edited

Loading

pawelprazak May 16, 2024 •

edited

Loading