Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhauled ResourceOptions and implemented Remote Components #355

Merged
merged 12 commits into from
Jan 30, 2024
Merged

Overhauled ResourceOptions and implemented Remote Components #355

merged 12 commits into from
Jan 30, 2024

Conversation

lbialy
Copy link
Collaborator

@lbialy lbialy commented Jan 28, 2024

as in title

pawelprazak
pawelprazak approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@pawelprazak pawelprazak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, looks great!

core/src/main/scala/besom/internal/Input.scala
@@ -53,6 +54,13 @@ object Input:
val outputList = inputList.map(simpleInputOps.asOutput(_)(isSecret = isSecret))
Output.sequence(outputList)

extension [A](input: Input.OneOrList[A])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@lbialy lbialy added area/core The SDK's core code impact/first-48 This bug is likely to be hit during a user's first 48 hours of product evaluation area/api User visible API labels Jan 30, 2024
@lbialy lbialy changed the title Implemented ResourceOptions with magnet function pattern and Inputs Overhauled ResourceOptions and implemented Remote Components Jan 30, 2024
@lbialy
Copy link
Collaborator Author

lbialy commented Jan 30, 2024

closes #307 and #284

This was referenced Jan 30, 2024
Closed
Closed
Closed
Closed
Closed
@pawelprazak pawelprazak mentioned this pull request Jan 30, 2024
Merged
@lbialy lbialy merged commit 8e6f951 into develop Jan 30, 2024
3 of 4 checks passed
@lbialy lbialy deleted the issue-307-redesign-resource-options branch January 30, 2024 20:50
@pawelprazak pawelprazak added this to the 0.2.0 milestone Feb 6, 2024
@lbialy lbialy mentioned this pull request Feb 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelprazak pawelprazak pawelprazak approved these changes

Assignees
No one assigned
Labels
area/api User visible API area/core The SDK's core code impact/first-48 This bug is likely to be hit during a user's first 48 hours of product evaluation
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lbialy @pawelprazak