Fix URL validation to allow for kubernetes types #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow for a dot in the URN's module part
pawelprazak
force-pushed
the
pprazak/fix-url-parser
branch
from
4e900bd to
0d37ee3
Compare
lbialy
approved these changes
Feb 10, 2024
|
We have a good indication from the codegen. Not that much. A mitigation strategy would be to unify the Pulumi model in a common module, for things like type tokens and urn's, but we'd have to carefully think it through first. The benefit would be that we already know from codegen what kind of exceptions are there in all schemas in the registry. The downside would be the coupling and more moving parts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #384