Memoization of pulumi side effects #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelprazak
approved these changes
Apr 2, 2024
| parsed <- parseInvokeResponse(tok, res) | ||
| yield parsed | ||
| end executeInvoke | ||
|
|
||
| private[internal] def resolveMode(options: ResourceOptions): Result[Mode] = | ||
| // this order is then repeated in registerReadOrGetResource | ||
| options.hasURN.zip(options.hasImportId).flatMap { case (hasUrn, hasImportId) => |
There was a problem hiding this comment.
Nit: I'd move this internal logic to the companion object of the Mode and use pat-mat instead of if for readability because it allow for a sort of "table of allowed states"
There was a problem hiding this comment.
can't be patmat, this is async
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final solution for memo issues.